rustc: Rename bmi feature to bmi1
#48565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is what [Intel calls it][bmi1] and will [remove a special case][stdsimd] when verifying intrinsics in stdsimd. [bmi1]: https://software.intel.com/sites/landingpage/IntrinsicsGuide/#othertechs=BMI1 [stdsimd]: https://github.com/rust-lang-nursery/stdsimd/blob/bed25b2a9f3b28e6ea80de6d87842f739a2e2d58/crates/stdsimd-verify/tests/x86-intel.rs#L252-L258
|
r? @cramertj (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
r=me when travis is happy. |
|
@bors: r=cramertj |
|
📌 Commit c133a08 has been approved by |
bors
added
S-waiting-on-bors
|
@bors rollup |
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Feb 27, 2018
rustc: Rename `bmi` feature to `bmi1` This is what [Intel calls it][bmi1] and will [remove a special case][stdsimd] when verifying intrinsics in stdsimd. [bmi1]: https://software.intel.com/sites/landingpage/IntrinsicsGuide/#othertechs=BMI1 [stdsimd]: https://github.com/rust-lang-nursery/stdsimd/blob/bed25b2a9f3b28e6ea80de6d87842f739a2e2d58/crates/stdsimd-verify/tests/x86-intel.rs#L252-L258
kennytm
added a commit
to kennytm/rust
that referenced
this pull request
Feb 28, 2018
rustc: Rename `bmi` feature to `bmi1` This is what [Intel calls it][bmi1] and will [remove a special case][stdsimd] when verifying intrinsics in stdsimd. [bmi1]: https://software.intel.com/sites/landingpage/IntrinsicsGuide/#othertechs=BMI1 [stdsimd]: https://github.com/rust-lang-nursery/stdsimd/blob/bed25b2a9f3b28e6ea80de6d87842f739a2e2d58/crates/stdsimd-verify/tests/x86-intel.rs#L252-L258
bors
added a commit
that referenced
this pull request
Feb 28, 2018
alexcrichton
added a commit
to rust-lang/stdarch
that referenced
this pull request
Mar 2, 2018
In accordance with rust-lang/rust#48565
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what Intel calls it and will remove a special case
when verifying intrinsics in stdsimd.