Rollup of 9 pull requests #48526
Closed
Rollup of 9 pull requests #48526
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Manishearth
commented
Feb 25, 2018
Manishearth
commented
- Successful merges: Stabilize FusedIterator #47463, rustdoc: Foldable impl blocks #47894, Add Condvar APIs not susceptible to spurious wake #47970, change opt-level 2 to 3 in bootstrap rustflags #48204, Move macro-at-most-once-rep-ambig test to ui test #48302, Add tests ensuring zero-Duration timeouts result in errors; fix Redox issues. #48330, Rename rdrnd target feature to rdrand #48369, Anonymize some line numbers in UI test output #48449, Add support for powerpc-unknown-linux-gnuspe #48484
- Failed merges: Add Iterator::flatten #48115
FusedIterator is a marker trait that promises that the implementing iterator continues to return `None` from `.next()` once it has returned `None` once (and/or `.next_back()`, if implemented). The effects of FusedIterator are already widely available through `.fuse()`, but with stable `FusedIterator`, stable Rust users can implement this trait for their iterators when appropriate.
Addresses rust-lang#40363, rust-lang#45720, rust-lang#24483, rust-lang#23986 and so on * Expands and refactors collapseDocs and toggleAllDocs * Adds [-] toggle to all impls (including inherent impl) * Makes it hiding though main css file, not though element style May need to be addressed: * "[-]" and anchor link copier are overlaid a bit * Inherent methods are also hidden by the global [-] toggle. * Auto-collapsing "Iterator" and so on by default is not implemented yet * Tested only shallowly and only in Chromiuim * No tests. Are there tests for css/js part here? * The new implementation may be a bit slower.
Provide wait_until and wait_timeout_until helper wrappers that aren't susceptible to spurious wake.
Make condition closure accept mut T&. Clarify spurious wakeup documentation. Cleanup doc example code.
This reverts commit 0885865.
Switch feature guards to unstable Add missing semicolon Remove mut that's no longer necessary
Also fix some code snippets in documentation.
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit 7d07940b10ac15365a4069a40919da1b870233a6 with merge 9fee4c86a3832cb41890286bf3808a1e56f3ef8b... |
…umeGomez,QuietMisdreavus rustdoc: Foldable impl blocks Addresses rust-lang#40363, rust-lang#45720, rust-lang#24483, rust-lang#23986 and so on * Expands and refactors collapseDocs and toggleAllDocs * Adds [-] toggle to all impls (including inherent impl) * Makes it hiding though main css file, not though element inline style May need to be addressed: * "[-]" and anchor link copier are overlaid a bit * Inherent methods are also hidden by the global [-] toggle. * Auto-collapsing "Iterator" and so on by default is not implemented yet * Tested only shallowly and only in Chromiuim * No tests. Are there tests for css/js part here? * The new implementation may be a bit slower. What next steps are need to be done before the integration?
Add Condvar APIs not susceptible to spurious wake Provide wait_until and wait_timeout_until helper wrappers that aren't susceptible to spurious wake. Additionally wait_timeout_until makes it possible to more easily write code that waits for a fixed amount of time in face of spurious wakes since otherwise each user would have to do math on adjusting the duration. Implements rust-lang#47960.
…kennytm change opt-level 2 to 3 in bootstrap rustflags Since llvm got updated, maybe this also resolved unexpected crashes. See discussion here: rust-lang@409d40f Is it possible to give this a test-run? //cc @Mark-Simulacrum
Move macro-at-most-once-rep-ambig test to ui test I had written this test for the feature. Now moving to ui test.
…on, r=sfackler Add tests ensuring zero-Duration timeouts result in errors; fix Redox issues. Part of rust-lang#48311
Rename rdrnd target feature to rdrand Plus minor cleanup. Related stdsimd [issue](rust-lang/stdarch#325).
Anonymize some line numbers in UI test output New unstable flag `-Z ui-testing` is introduced. This flag changes diagnostic output of the compiler *in some way* making it more suitable for UI testing (this is intentionally vague). At the moment this flag anonymizes line numbers at line starts thus solving the largest issue with UI test diffs. If diffs continue to be too noisy, some other tweaks could be applied (e.g. anonymizing lines/columns in `--> $DIR/file.rs:line:column`), but this needs some time and experience (we shouldn't diverge too much from the actual output in general). If comment `// disable-ui-testing-normalization` is added to an UI test, then `-Z ui-testing` is not passed. Closes rust-lang#46643
…ichton Add support for powerpc-unknown-linux-gnuspe This PR adds support for the embedded PowerPC variant "e500". On Linux, this architecture is usually called "powerpcspe", it is a 32-bit PowerPC architecture. The main difference between normal 32-bit PowerPC and PowerPCSPE is the lack of Altivec instructions and the additional SPE instruction set. This architecture is supported in Debian through an unofficial port.
|
@bors r+ |
|
📌 Commit ee8fc49 has been approved by |
|
⌛ Testing commit ee8fc49 with merge 7b6189e16439a5c37c46992d44f363d0c2f63b3b... |
|
💔 Test failed - status-appveyor |
bors
added
S-waiting-on-review
|
Windows access violation (segfault) when compiling stage1-rustc for x86_64-pc-windows-msvc. Perhaps take out #48204. Additionally, there are UI errors from the CI due to the line-number anonymization PR #48449. |
kennytm
added
S-waiting-on-author
|
@bors treeclosed- |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.