-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add nonstandard_style alias for bad_style. #48386
Merged
Merged
Changes from 3 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,36 @@ | ||
// Copyright 2014–2017 The Rust Project Developers. See the COPYRIGHT | ||
// file at the top-level directory of this distribution and at | ||
// http://rust-lang.org/COPYRIGHT. | ||
// | ||
// Licensed under the Apache License, Version 2.0 <LICENSE-APACHE or | ||
// http://www.apache.org/licenses/LICENSE-2.0> or the MIT license | ||
// <LICENSE-MIT or http://opensource.org/licenses/MIT>, at your | ||
// option. This file may not be copied, modified, or distributed | ||
// except according to those terms. | ||
|
||
#![deny(nonstandard_style)] | ||
#![allow(dead_code)] | ||
|
||
fn CamelCase() {} //~ ERROR should have a snake | ||
|
||
#[allow(bad_style)] | ||
mod test { | ||
fn CamelCase() {} | ||
|
||
#[forbid(bad_style)] | ||
mod bad { | ||
fn CamelCase() {} //~ ERROR should have a snake | ||
|
||
static bad: isize = 1; //~ ERROR should have an upper | ||
} | ||
|
||
mod warn { | ||
#![warn(bad_style)] | ||
|
||
fn CamelCase() {} //~ WARN should have a snake | ||
|
||
struct snake_case; //~ WARN should have a camel | ||
} | ||
} | ||
|
||
fn main() {} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
error: function `CamelCase` should have a snake case name such as `camel_case` | ||
--> $DIR/lint-group-nonstandard-style.rs:14:1 | ||
| | ||
14 | fn CamelCase() {} //~ ERROR should have a snake | ||
| ^^^^^^^^^^^^^^^^^ | ||
| | ||
note: lint level defined here | ||
--> $DIR/lint-group-nonstandard-style.rs:11:9 | ||
| | ||
11 | #![deny(nonstandard_style)] | ||
| ^^^^^^^^^^^^^^^^^ | ||
= note: #[deny(non_snake_case)] implied by #[deny(nonstandard_style)] | ||
|
||
error: function `CamelCase` should have a snake case name such as `camel_case` | ||
--> $DIR/lint-group-nonstandard-style.rs:22:9 | ||
| | ||
22 | fn CamelCase() {} //~ ERROR should have a snake | ||
| ^^^^^^^^^^^^^^^^^ | ||
| | ||
note: lint level defined here | ||
--> $DIR/lint-group-nonstandard-style.rs:20:14 | ||
| | ||
20 | #[forbid(nonstandard_style)] | ||
| ^^^^^^^^^^^^^^^^^ | ||
= note: #[forbid(non_snake_case)] implied by #[forbid(nonstandard_style)] | ||
|
||
error: static variable `bad` should have an upper case name such as `BAD` | ||
--> $DIR/lint-group-nonstandard-style.rs:24:9 | ||
| | ||
24 | static bad: isize = 1; //~ ERROR should have an upper | ||
| ^^^^^^^^^^^^^^^^^^^^^^ | ||
| | ||
note: lint level defined here | ||
--> $DIR/lint-group-nonstandard-style.rs:20:14 | ||
| | ||
20 | #[forbid(nonstandard_style)] | ||
| ^^^^^^^^^^^^^^^^^ | ||
= note: #[forbid(non_upper_case_globals)] implied by #[forbid(nonstandard_style)] | ||
|
||
warning: function `CamelCase` should have a snake case name such as `camel_case` | ||
--> $DIR/lint-group-nonstandard-style.rs:30:9 | ||
| | ||
30 | fn CamelCase() {} //~ WARN should have a snake | ||
| ^^^^^^^^^^^^^^^^^ | ||
| | ||
note: lint level defined here | ||
--> $DIR/lint-group-nonstandard-style.rs:28:17 | ||
| | ||
28 | #![warn(nonstandard_style)] | ||
| ^^^^^^^^^^^^^^^^^ | ||
= note: #[warn(non_snake_case)] implied by #[warn(nonstandard_style)] | ||
|
||
warning: type `snake_case` should have a camel case name such as `SnakeCase` | ||
--> $DIR/lint-group-nonstandard-style.rs:32:9 | ||
| | ||
32 | struct snake_case; //~ WARN should have a camel | ||
| ^^^^^^^^^^^^^^^^^^ | ||
| | ||
note: lint level defined here | ||
--> $DIR/lint-group-nonstandard-style.rs:28:17 | ||
| | ||
28 | #![warn(nonstandard_style)] | ||
| ^^^^^^^^^^^^^^^^^ | ||
= note: #[warn(non_camel_case_types)] implied by #[warn(nonstandard_style)] | ||
|
||
error: aborting due to 3 previous errors | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is such a downer.