Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove allocation from width of character function. #48167

Merged
merged 1 commit into from
Feb 15, 2018
Merged

Remove allocation from width of character function. #48167

merged 1 commit into from
Feb 15, 2018

Conversation

Mark-Simulacrum
Copy link
Member

@Mark-Simulacrum Mark-Simulacrum commented Feb 12, 2018 •
edited
Loading

Locally this seems to eliminate the problem or at least resolve most of the
issue.

Fixes #48153.

r? @estebank

@estebank
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Feb 12, 2018

📌 Commit f237e9e has been approved by estebank

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 12, 2018
@Mark-Simulacrum Mark-Simulacrum added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Feb 12, 2018
@Mark-Simulacrum
Copy link
Member Author

I've nominated this for beta backport, as it's a small patch that fixes a major regression (40 minute long compile times vs 150 seconds), and if we cut beta before this lands (likely) this is good to get in.

@Mark-Simulacrum Mark-Simulacrum added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Feb 13, 2018
kennytm added a commit to kennytm/rust that referenced this pull request Feb 13, 2018
@kennytm
Rollup merge of rust-lang#48167 - Mark-Simulacrum:remove-allocation-c…
5b25477 
…odemap, r=estebank

Remove allocation from width of character function.

Locally this seems to eliminate the problem or at least resolve most of the
issue.

Fixes rust-lang#48153.

r? @estebank
@kennytm kennytm mentioned this pull request Feb 13, 2018
Closed
bors added a commit that referenced this pull request Feb 13, 2018
@bors
Auto merge of #48177 - kennytm:rollup, r=kennytm
1811c36 
Rollup of 14 pull requests

- Successful merges: #47784, #47846, #48033, #48083, #48087, #48114, #48126, #48130, #48133, #48151, #48154, #48163, #48165, #48167
- Failed merges:
@kennytm kennytm mentioned this pull request Feb 14, 2018
Merged
kennytm added a commit to kennytm/rust that referenced this pull request Feb 14, 2018
@kennytm
Rollup merge of rust-lang#48167 - Mark-Simulacrum:remove-allocation-c…
dc9d93f 
…odemap, r=estebank

Remove allocation from width of character function.

Locally this seems to eliminate the problem or at least resolve most of the
issue.

Fixes rust-lang#48153.

r? @estebank
bors added a commit that referenced this pull request Feb 14, 2018
@bors
Auto merge of #48203 - kennytm:rollup, r=kennytm
d3fb063 
Rollup of 22 pull requests

- Successful merges: #47784, #47806, #47846, #48005, #48033, #48065, #48087, #48114, #48126, #48130, #48133, #48151, #48154, #48156, #48162, #48163, #48165, #48167, #48181, #48186, #48195, #48035
- Failed merges:
bors added a commit that referenced this pull request Feb 15, 2018
@bors
Auto merge of #48203 - kennytm:rollup, r=kennytm
f6ee1ec 
Rollup of 22 pull requests

- Successful merges: #47784, #47806, #47846, #48005, #48033, #48065, #48087, #48114, #48126, #48130, #48133, #48151, #48154, #48156, #48162, #48163, #48165, #48167, #48181, #48186, #48195, #48035
- Failed merges:
bors added a commit that referenced this pull request Feb 15, 2018
@bors
Auto merge of #48203 - kennytm:rollup, r=kennytm
1670a53 
Rollup of 23 pull requests

- Successful merges: #47784, #47806, #47846, #48005, #48033, #48065, #48087, #48114, #48126, #48130, #48133, #48151, #48154, #48156, #48162, #48163, #48165, #48167, #48181, #48186, #48195, #48035, #48210
- Failed merges:
@kennytm kennytm merged commit f237e9e into rust-lang:master Feb 15, 2018
@Mark-Simulacrum Mark-Simulacrum deleted the remove-allocation-codemap branch March 4, 2018 02:10
@Mark-Simulacrum Mark-Simulacrum restored the remove-allocation-codemap branch March 4, 2018 02:10
@Mark-Simulacrum
Copy link
Member Author

@rust-lang/release Would anyone be interested in making a beta backport of this? Process is described here: https://forge.rust-lang.org/beta-backporting.html

@XAMPPRocky
Copy link
Member

@Mark-Simulacrum I'll take this one if it's no problem.

@XAMPPRocky XAMPPRocky mentioned this pull request Mar 4, 2018
Merged
@kennytm kennytm removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Mar 4, 2018
bors added a commit that referenced this pull request Mar 4, 2018
@bors
Auto merge of #48730 - Aaronepower:upstream-beta, r=kennytm
ac3e34e 
[beta] Remove allocation from width of character function.

Backport of #48167

r? @Mark-Simulacrum
bors added a commit that referenced this pull request Mar 5, 2018
@bors
Auto merge of #48730 - Aaronepower:upstream-beta, r=kennytm
e93f6e0 
[beta] Remove allocation from width of character function.

Backport of #48167

r? @Mark-Simulacrum
@Mark-Simulacrum Mark-Simulacrum deleted the remove-allocation-codemap branch June 8, 2019 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@estebank estebank

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compiler slowdown on lage module in nightly
5 participants
@Mark-Simulacrum @estebank @bors @XAMPPRocky @kennytm