Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Prepare stable release for 1.24.0 #48161

Merged
merged 1 commit into from
Feb 12, 2018
Merged

Prepare stable release for 1.24.0 #48161

merged 1 commit into from
Feb 12, 2018

Conversation

Mark-Simulacrum
Copy link
Member

Cargo submodule appears to already be at tip and RLS has no branch to sync to (or 1.23.0 branch).

@rust-highfive
Copy link
Collaborator

r? @aturon

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

warning Warning warning

  • Pull requests are usually filed against the master branch for this repo, but this one is against stable. Please double check that you specified the right target!

@Mark-Simulacrum
Copy link
Member Author

This is the stable release!

@bors r+ p=1000

@bors
Copy link
Contributor

bors commented Feb 12, 2018

📌 Commit 6414431 has been approved by Mark-Simulacrum

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Feb 12, 2018
bors added a commit that referenced this pull request Feb 12, 2018
@bors
Auto merge of #48161 - Mark-Simulacrum:stable-next, r=Mark-Simulacrum
07aa423 
Prepare stable release for 1.24.0

Cargo submodule appears to already be at tip and RLS has no branch to sync to (or 1.23.0 branch).
@bors
Copy link
Contributor

bors commented Feb 12, 2018

⌛ Testing commit 6414431 with merge 07aa423...

@bors
Copy link
Contributor

bors commented Feb 12, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 12, 2018
@Mark-Simulacrum
Copy link
Member Author

@bors retry -- appveyor timed out

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 12, 2018
@bors
Copy link
Contributor

bors commented Feb 12, 2018

⌛ Testing commit 6414431 with merge 4d90ac3...

bors added a commit that referenced this pull request Feb 12, 2018
@bors
Auto merge of #48161 - Mark-Simulacrum:stable-next, r=Mark-Simulacrum
4d90ac3 
Prepare stable release for 1.24.0

Cargo submodule appears to already be at tip and RLS has no branch to sync to (or 1.23.0 branch).
@bors
Copy link
Contributor

bors commented Feb 12, 2018

💔 Test failed - status-appveyor

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Feb 12, 2018
@alexcrichton alexcrichton merged commit 6414431 into rust-lang:stable Feb 12, 2018
@alexcrichton
Copy link
Member

Not today AppVeyor, not today.

@Mark-Simulacrum Mark-Simulacrum deleted the stable-next branch February 13, 2018 00:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@aturon aturon

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Mark-Simulacrum @rust-highfive @bors @alexcrichton @aturon