-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 8 pull requests #47572
Rollup of 8 pull requests #47572
Commits on Dec 22, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 176624f - Browse repository at this point
Copy the full SHA 176624fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6e741df - Browse repository at this point
Copy the full SHA 6e741dfView commit details
Commits on Jan 15, 2018
-
removed styling of dt tages, which would make them look like keys and added <kbd> tag inside of dt tag. Added css style for kbd and removed some stylings for dt
Configuration menu - View commit details
-
Copy full SHA for 38e5d30 - Browse repository at this point
Copy the full SHA 38e5d30View commit details -
Only link res_init() on GNU/*nix
To workaround a bug in glibc <= 2.26 lookup_host() calls res_init() based on the glibc version detected at runtime. While this avoids calling res_init() on platforms where it's not required we will still end up linking against the symbol. This causes an issue on macOS where res_init() is implemented in a separate library (libresolv.9.dylib) from the main libc. While this is harmless for standalone programs it becomes a problem if Rust code is statically linked against another program. If the linked program doesn't already specify -lresolv it will cause the link to fail. This is captured in issue rust-lang#46797 Fix this by hooking in to the glibc workaround in `cvt_gai` and only activating it for the "gnu" environment on Unix This should include all glibc platforms while excluding musl, windows-gnu, macOS, FreeBSD, etc. This has the side benefit of removing the #[cfg] in sys_common; only unix.rs has code related to the workaround now.
Configuration menu - View commit details
-
Copy full SHA for 090a968 - Browse repository at this point
Copy the full SHA 090a968View commit details
Commits on Jan 17, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 0e1ecbe - Browse repository at this point
Copy the full SHA 0e1ecbeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 839ff6f - Browse repository at this point
Copy the full SHA 839ff6fView commit details -
Configuration menu - View commit details
-
Copy full SHA for 13f8c82 - Browse repository at this point
Copy the full SHA 13f8c82View commit details -
Configuration menu - View commit details
-
Copy full SHA for b7228c8 - Browse repository at this point
Copy the full SHA b7228c8View commit details -
Configuration menu - View commit details
-
Copy full SHA for ee606c0 - Browse repository at this point
Copy the full SHA ee606c0View commit details -
Replaced multi-byte character handling in end_point with potentially …
…more performant variant.
Configuration menu - View commit details
-
Copy full SHA for e1c927b - Browse repository at this point
Copy the full SHA e1c927bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9d4ca01 - Browse repository at this point
Copy the full SHA 9d4ca01View commit details -
Configuration menu - View commit details
-
Copy full SHA for 2161c3f - Browse repository at this point
Copy the full SHA 2161c3fView commit details -
Configuration menu - View commit details
-
Copy full SHA for a1b72f7 - Browse repository at this point
Copy the full SHA a1b72f7View commit details
Commits on Jan 18, 2018
-
Deprecate std::net::lookup_host
We intended to do this quite a while ago but it snuck through.
Configuration menu - View commit details
-
Copy full SHA for 908aa38 - Browse repository at this point
Copy the full SHA 908aa38View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0c946c0 - Browse repository at this point
Copy the full SHA 0c946c0View commit details -
Configuration menu - View commit details
-
Copy full SHA for f66e711 - Browse repository at this point
Copy the full SHA f66e711View commit details -
Configuration menu - View commit details
-
Copy full SHA for 005791b - Browse repository at this point
Copy the full SHA 005791bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9a4287d - Browse repository at this point
Copy the full SHA 9a4287dView commit details
Commits on Jan 19, 2018
-
Rollup merge of rust-lang#46938 - hellow554:rustdoc-kbd-style, r=Guil…
…laumeGomez add kbd style tag to main.css in rustdoc Added css style for kbd tags so they actually look like keys. Result preview and discussion was going on in rust-lang#46900 .
Configuration menu - View commit details
-
Copy full SHA for 6e9cbac - Browse repository at this point
Copy the full SHA 6e9cbacView commit details -
Rollup merge of rust-lang#47334 - etaoins:only-call-res-init-on-gnu-u…
…nix, r=alexcrichton Only link res_init() on GNU/*nix To workaround a bug in glibc <= 2.26 lookup_host() calls res_init() based on the glibc version detected at runtime. While this avoids calling res_init() on platforms where it's not required we will still end up linking against the symbol. This causes an issue on macOS where res_init() is implemented in a separate library (libresolv.9.dylib) from the main libc. While this is harmless for standalone programs it becomes a problem if Rust code is statically linked against another program. If the linked program doesn't already specify -lresolv it will cause the link to fail. This is captured in issue rust-lang#46797 Fix this by hooking in to the glibc workaround in `cvt_gai` and only activating it for the "gnu" environment on Unix This should include all glibc platforms while excluding musl, windows-gnu, macOS, FreeBSD, etc. This has the side benefit of removing the #[cfg] in sys_common; only unix.rs has code related to the workaround now. Before this commit: ```shell > cat main.rs use std::net::ToSocketAddrs; #[no_mangle] pub extern "C" fn resolve_test() -> () { let addr_list = ("google.com.au", 0).to_socket_addrs().unwrap(); println!("{:?}", addr_list); } > rustc --crate-type=staticlib main.rs > clang libmain.a test.c -o combined Undefined symbols for architecture x86_64: "_res_9_init", referenced from: std::net::lookup_host::h93c17fe9ad38464a in libmain.a(std-826c8d3b356e180c.std0.rcgu.o) ld: symbol(s) not found for architecture x86_64 clang-5.0: error: linker command failed with exit code 1 (use -v to see invocation) ``` Afterwards: ```shell > rustc --crate-type=staticlib main.rs > clang libmain.a test.c -o combined > ./combined IntoIter([V4(172.217.25.131:0)]) ``` Fixes rust-lang#46797
Configuration menu - View commit details
-
Copy full SHA for df40c4a - Browse repository at this point
Copy the full SHA df40c4aView commit details -
Rollup merge of rust-lang#47420 - davidtwco:issue-46885, r=estebank
Fix off-by-one spans in MIR borrowck errors Fixes rust-lang#46885. r? @nikomatsakis
Configuration menu - View commit details
-
Copy full SHA for ac75587 - Browse repository at this point
Copy the full SHA ac75587View commit details -
Rollup merge of rust-lang#47508 - QuietMisdreavus:rbe-bookshelf, r=st…
…eveklabnik add Rust By Example to the bookshelf cc rust-lang#46194 With rust-lang#46196 freshly merged, we should add a link to the main docs distribution so people can find it! We discussed this at the docs team meeting today and decided to go ahead with adding it to the bookshelf.
Configuration menu - View commit details
-
Copy full SHA for c71ea45 - Browse repository at this point
Copy the full SHA c71ea45View commit details -
Rollup merge of rust-lang#47510 - sfackler:deprecate-dns, r=alexcrichton
Deprecate std::net::lookup_host We intended to do this quite a while ago but it snuck through. r? @alexcrichton
Configuration menu - View commit details
-
Copy full SHA for c71bc78 - Browse repository at this point
Copy the full SHA c71bc78View commit details -
Rollup merge of rust-lang#47512 - GuillaumeGomez:e0659, r=petrochenkov
Add E0659 for ambiguous names Still on the tracks of the "no error without error code" road.
Configuration menu - View commit details
-
Copy full SHA for 223b474 - Browse repository at this point
Copy the full SHA 223b474View commit details -
Rollup merge of rust-lang#47535 - Manishearth:ignore-target, r=kennytm
add target/ to ignored tidy dirs Sometimes you get a target directory from running cargo in the rust repo (the root is `src/`), and it contains generated files. Just whitelist it since it causes tidy to spew warnings uncontrollably.
Configuration menu - View commit details
-
Copy full SHA for 3171cdf - Browse repository at this point
Copy the full SHA 3171cdfView commit details -
Rollup merge of rust-lang#47559 - walinga:pr-link-fix, r=kennytm
Fix the "Github - About Pull Requests" link in CONTRIBUTING.md Previously the text that is supposed to link to the Github Pull Requests page, instead linked to the same file (CONTRIBUTING.md).
Configuration menu - View commit details
-
Copy full SHA for ce797d5 - Browse repository at this point
Copy the full SHA ce797d5View commit details