Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend macro name suggestion span #47424

Closed
wants to merge 1 commit into from
Closed

Extend macro name suggestion span #47424

wants to merge 1 commit into from

Commits on Jan 14, 2018

  1. Extend macro suggestion span 

    When we suggest the replacement for a macro we include the "!" in the
suggested replacement but the span only contains the name of the macro
itself. Using that replacement would cause a duplicate "!" in the
resulting code.

Fix by extending the suggestion's span by one byte to include the "!".
The error span itself still only includes the macro's name.

Fixes #47418
    @etaoins
    etaoins committed Jan 14, 2018
    Configuration menu
    Copy the full SHA
    9704aa0 View commit details
    Browse the repository at this point in the history