Update check::cast::pointer_kind logic to new rustc #46973
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make the match exhaustive, adding handling for anonymous types and tuple coercions on the way. Also, exit early when type errors are detected, to avoid error cascades and the like.
arielb1
added
the
beta-nominated
|
r? @estebank (rust_highfive has picked a reviewer for you, use r? to override) |
|
beta-nominating because regressioin |
These can happen if prior errors disable defaulting. Fixes rust-lang#43825.
kennytm
added
the
S-waiting-on-review
|
@bors r+ p=1 |
|
📌 Commit 6aca330 has been approved by |
|
⌛ Testing commit 6aca330 with merge f6627b9b73f6160edec871ff21afd05ffaf1fff9... |
|
💔 Test failed - status-travis |
|
⌛ Testing commit 6aca330 with merge 1dc9c64e04f149a00a83898868e2e6234c7ac04b... |
|
💔 Test failed - status-travis |
|
☀️ Test successful - status-appveyor, status-travis |
nagisa
added
the
T-compiler
|
Unfortunately we forgot to backport to 1.23.0 (sorry about that!) so removing beta tags |
alexcrichton
removed
the
beta-nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make the match exhaustive, adding handling for anonymous types and
tuple coercions on the way.
Also, exit early when type errors are detected, to avoid error cascades
and the like.
Fixes #33690.
Fixes #46365.
Fixes #46880.