Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove a token after closing delimiter from the span of macro in type position #46835

Merged
merged 2 commits into from
Dec 20, 2017
Merged

Remove a token after closing delimiter from the span of macro in type position #46835

merged 2 commits into from
Dec 20, 2017

Conversation

topecongiro
Copy link
Contributor

e.g.

let x = y: foo!();

The span for foo!() includes ;.

cc rust-lang/rustfmt#2290.

@rust-highfive
Copy link
Collaborator

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@topecongiro topecongiro force-pushed the bad-span-for-macro-invocation-in-type branch from 4fd04f9 to e0e62fc Compare December 19, 2017 16:22
@petrochenkov
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Dec 19, 2017

📌 Commit e0e62fc has been approved by petrochenkov

@topecongiro topecongiro mentioned this pull request Dec 20, 2017
Closed
kennytm added a commit to kennytm/rust that referenced this pull request Dec 20, 2017
@kennytm
Rollup merge of rust-lang#46835 - topecongiro:bad-span-for-macro-invo…
99fdca0 
…cation-in-type, r=petrochenkov

Remove a token after closing delimiter from the span of macro in type position

e.g.
```rust
let x = y: foo!();
```
The span for `foo!()` includes `;`.

cc rust-lang/rustfmt#2290.
@kennytm kennytm mentioned this pull request Dec 20, 2017
Merged
@kennytm kennytm added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Dec 20, 2017
bors added a commit that referenced this pull request Dec 20, 2017
@bors
Auto merge of #46874 - kennytm:rollup, r=kennytm
81622c6 
Rollup of 14 pull requests

- Successful merges: #46359, #46517, #46671, #46751, #46760, #46787, #46794, #46828, #46831, #46835, #46851, #46852, #46856, #46870
- Failed merges:
@bors bors merged commit e0e62fc into rust-lang:master Dec 20, 2017
@topecongiro topecongiro deleted the bad-span-for-macro-invocation-in-type branch December 20, 2017 23:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@topecongiro @rust-highfive @petrochenkov @bors @kennytm