Rollup of 13 pull requests #46430
Merged
Rollup of 13 pull requests #46430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...that were removed in 77c3bfa.
The documentation states: "The name output should be the name of the library." and this is already done in more recently-added callers.
The usage of `Path::new` prevented out-of-tree builds (like the bots do) from working by accident! Closes rust-lang#46195
We want librustdoc to pickup the env_logger dependency from the sysroot. This ensures that the same copy of env_logger is used for both internal crates (e.g. librustc_driver, libsyntax) and librustdoc Closes rust-lang#46383
Rustoc item summaries that are headers were not displayed at all because they started with whitespace. This PR fixes this and now removes the whitespace and then displays the block.
rust-lang/cargo@5bb478a Pick up `workspace.default-members` support: rust-lang/cargo#4743
This was added to cover up a lazy extra semicolon in rust-lang#35849, but does not actually make sense. This is removed as a part of the stabilization of `never_type`.
This commit updates LLVM with some tweaks to the integer <-> floating point conversion instructions to ensure that `as` in Rust doesn't trap. Closes rust-lang#46298
Rustdoc has for some time now used the "everybody loops" pass in the compiler to avoid typechecking and otherwise avoid looking at implementation details. In rust-lang#46115 the placement of this pass was pushed back in the compiler to after macro expansion to ensure that it works with macro-expanded code as well. This in turn caused the regression in rust-lang#46271. The bug here was that the resolver was producing `def_id` instances for "possibly unused extern crates" which would then later get processed during typeck to actually issue lint warnings. The problem was that *after* resolution these `def_id` nodes were actually removed from the AST by the "everybody loops" pass. This later, when we tried to take a look at `def_id`, caused the compiler to panic. The fix applied here is a bit of a heavy hammer which is to just, in this one case, ignore the `extern crate` lints if the `def_id` looks "bogus" in any way (basically if it looks like the node was removed after resolution). The real underlying bug here is probably that the "everybody loops" AST pass is being stressed to much beyond what it was originally intended to do, but this should at least fix the ICE for now... Closes rust-lang#46271
Use the CTL_KERN.KERN_PROC_ARGS.-1.KERN_PROC_PATHNAME sysctl in preference over the /proc/curproc/exe symlink. Additionally, perform more validation of aformentioned symlink. Particularly on pre-8.x NetBSD this symlink will point to '/' when accurate information is unavailable.
When using `#[doc(hidden)]` elements are hidden from docs even when the rustdoc flag `--document-private-items` is set. This behavior has been changed to display all hidden items when the flag is active.
Trait's implementations with private type parameters were displayed in the implementing struct's documentation until now. With this change any trait implementation that uses a private type parameter is now hidden in the docs.
After renaming the structs and enums the htmldocck strings still contained the old names. This lead to test failure. These htmldocck tests have been updated to use the proper names of the rust structs and traits.
Function "up_to_date" return incorrect result if mtime for all fetched sources is set to epoch time. Add existence check to function.
make coercions to `!` in unreachable code a hard error This was added to cover up a lazy extra semicolon in rust-lang#35849, but does not actually make sense. This is removed as a part of the stabilization of `never_type`.
rustc_llvm: remove stale references ...that were removed in 77c3bfa. r? @alexcrichton
… r=kennytm NetBSD: add sysctl backend for std::env::current_exe Use the CTL_KERN.KERN_PROC_ARGS.-1.KERN_PROC_PATHNAME sysctl in preference over the /proc/curproc/exe symlink. Additionally, perform more validation of aformentioned symlink. Particularly on pre-8.x NetBSD this symlink will point to '/' when accurate information is unavailable.
Update Cargo to Wed Nov 29 15:19:05 2017 +0000 rust-lang/cargo@5bb478a Pick up `workspace.default-members` support: rust-lang/cargo#4743
…-Simulacrum rustbuild: Fix a typo with the Cargo book The usage of `Path::new` prevented out-of-tree builds (like the bots do) from working by accident! Closes rust-lang#46195
…imulacrum Remove librustdoc dependency on env_logger We want librustdoc to pickup the env_logger dependency from the sysroot. This ensures that the same copy of env_logger is used for both internal crates (e.g. librustc_driver, libsyntax) and librustdoc Closes rust-lang#46383
Fix rustdoc item summaries that are headers Rustoc item summaries that are headers were not displayed at all because they started with whitespace. This PR fixes this and now removes the whitespace and then displays the block. I'm not sure if the rustdoc test is written correctly, if there's anything to improve, just let me know. :) This fixes rust-lang#46377. This is how it looks when rendered out now: 
…Misdreavus Invert colors in important traits tooltip Part of rust-lang#46352. r? @QuietMisdreavus
…r=eddyb incr.comp.: Make traits::VTable encodable and decodable. Make vtables encodable so we can cache the `trans_fulfill_obligation` query at some point. r? @eddyb
wasm: Update LLVM to fix a test This commit updates LLVM with some tweaks to the integer <-> floating point conversion instructions to ensure that `as` in Rust doesn't trap. Closes rust-lang#46298
rustc: Filter out bogus extern crate warnings Rustdoc has for some time now used the "everybody loops" pass in the compiler to avoid typechecking and otherwise avoid looking at implementation details. In rust-lang#46115 the placement of this pass was pushed back in the compiler to after macro expansion to ensure that it works with macro-expanded code as well. This in turn caused the regression in rust-lang#46271. The bug here was that the resolver was producing `def_id` instances for "possibly unused extern crates" which would then later get processed during typeck to actually issue lint warnings. The problem was that *after* resolution these `def_id` nodes were actually removed from the AST by the "everybody loops" pass. This later, when we tried to take a look at `def_id`, caused the compiler to panic. The fix applied here is a bit of a heavy hammer which is to just, in this one case, ignore the `extern crate` lints if the `def_id` looks "bogus" in any way (basically if it looks like the node was removed after resolution). The real underlying bug here is probably that the "everybody loops" AST pass is being stressed to much beyond what it was originally intended to do, but this should at least fix the ICE for now... Closes rust-lang#46271
…reavus Hide private trait type params and show hidden items with document-private As discussed in rust-lang#46380, this PR removes the `strip-hidden` pass from `--document-private-items` which allows showing `#[doc(hidden)]` with rustdoc. The second commit removes the trait implementation from the docs if the trait's parameter is private.
build_helper: destination file can't be up to date when not exists Function "up_to_date" return incorrect result if mtime for all fetched sources is set to epoch time. Add existence check to function. This fix required for a [Guix](https://www.gnu.org/software/guix/) package because a Nix builder set mtime of all sources to epoch time.
|
Some changes occurred in HTML/CSS. |
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ p=13 |
|
📌 Commit 5617477 has been approved by |
kennytm
added
the
S-waiting-on-bors
|
☀️ Test successful - status-appveyor, status-travis |
This was referenced Dec 2, 2017
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
!in unreachable code a hard error #45880, rustc_llvm: remove stale references #46280, NetBSD: add sysctl backend for std::env::current_exe #46373, Update Cargo to Wed Nov 29 15:19:05 2017 +0000 #46376, rustbuild: Fix a typo with the Cargo book #46385, Remove librustdoc dependency on env_logger #46386, Fix rustdoc item summaries that are headers #46387, Invert colors in important traits tooltip #46392, incr.comp.: Make traits::VTable encodable and decodable. #46400, wasm: Update LLVM to fix a test #46401, rustc: Filter out bogus extern crate warnings #46405, Hide private trait type params and show hidden items with document-private #46412, build_helper: destination file can't be up to date when not exists #46421