Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add RefCell<T>::replace_with #45819

Merged
merged 1 commit into from
Nov 20, 2017
Merged

Add RefCell<T>::replace_with #45819

merged 1 commit into from
Nov 20, 2017

Conversation

Havvy
Copy link
Contributor

@Havvy Havvy commented Nov 7, 2017

I also moved the Panic sections to before examples in the other two functions also under this feature gate, and changed the variable names in replace to be more readable.

r? @rust-libs

@kennytm kennytm added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. labels Nov 7, 2017
@kennytm
Copy link
Member

kennytm commented Nov 7, 2017

(cc @rust-lang/libs)

@Havvy
Copy link
Contributor Author

Havvy commented Nov 10, 2017

r? @BurntSushi

Just to get some reviewer on this.

@shepmaster
Copy link
Member

Ping from triage, @BurntSushi — will you be able to spend some time on this?

@aturon
Copy link
Member

aturon commented Nov 20, 2017

@bors: r+

Thanks!

@bors
Copy link
Contributor

bors commented Nov 20, 2017

📌 Commit 2d02772 has been approved by aturon

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 20, 2017
@bors
Copy link
Contributor

bors commented Nov 20, 2017

⌛ Testing commit 2d02772 with merge 5802986...

bors added a commit that referenced this pull request Nov 20, 2017
Add RefCell<T>::replace_with

I also moved the `Panic` sections to before examples in the other two functions also under this feature gate, and changed the variable names in `replace` to be more readable.

r? @rust-libs
@bors
Copy link
Contributor

bors commented Nov 20, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: aturon
Pushing 5802986 to master...

@bors bors merged commit 2d02772 into rust-lang:master Nov 20, 2017
@RalfJung
Copy link
Member

In which sense does RefCell::replace_with correspond to std::mem::replace? It seems to me that part of the doc was accidentally copied?

@Havvy
Copy link
Contributor Author

Havvy commented Nov 29, 2017

In the same sense that RefCell::replace corresponds to mem::replace. Though with the with part, it doesn't correspond exactly. It could be worded more explicitly "Like RefCell::replace, this function corresponds to mem::replace."

@RalfJung
Copy link
Member

Well, RefCell::replace and RefCell::replace_with differ, so if mem::replace corresponds to the former, it doesn't correspond to the later. ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants