Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable clippy testing #45715

Merged
merged 1 commit into from
Nov 15, 2017
Merged

Reenable clippy testing #45715

merged 1 commit into from
Nov 15, 2017

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Nov 2, 2017

fixes #45680

@kennytm kennytm added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Nov 2, 2017
@kennytm
Copy link
Member

kennytm commented Nov 2, 2017

This should not land before #45247 (breaks rustfmt/rls) is merged.

@kennytm
Copy link
Member

kennytm commented Nov 4, 2017

@oli-obk #45427 is merged, could you verify if clippy can still be compiled or require another update? Thanks!

@oli-obk
Copy link
Contributor Author

oli-obk commented Nov 6, 2017

It required another update. I rebased over master and amended the commit.

@oli-obk
Copy link
Contributor Author

oli-obk commented Nov 8, 2017

Ping @kennytm

Not sure if it still builds though.

@kennytm
Copy link
Member

kennytm commented Nov 9, 2017

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Nov 9, 2017

📌 Commit e50d1aa has been approved by kennytm

@bors
Copy link
Contributor

bors commented Nov 9, 2017

⌛ Testing commit e50d1aaeb08314c36c9c5e94ef1977ef34c4fb14 with merge 231f61db1115b66102e3e2c324be51215e9b1a71...

@bors
Copy link
Contributor

bors commented Nov 9, 2017

💔 Test failed - status-travis

@kennytm
Copy link
Member

kennytm commented Nov 9, 2017

Two macOS builds (and only macs, strangely) failed. Looks like you do need to update again.

[01:19:46] error[E0608]: cannot index into a value of type `std::rc::Rc<std::collections::HashSet<rustc::hir::ItemLocalId, std::hash::BuildHasherDefault<rustc_data_structures::fx::FxHasher>>>`
[01:19:46]    --> src/tools/clippy/clippy_lints/src/methods.rs:893:26
[01:19:46]     |
[01:19:46] 893 |         let promotable = cx.tcx.rvalue_promotable_map(owner_def)[&arg.hir_id.local_id];
[01:19:46]     |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[01:19:46] 
[01:19:47] error: aborting due to previous error
[01:19:47] 
[01:19:47] error: Could not compile `clippy_lints`.
[01:19:47] warning: build failed, waiting for other jobs to finish...
[01:19:55] error: build failed

@@ -26,7 +26,7 @@
miri = "Broken"

# ping @Manishearth @llogiq @mcarton @oli-obk
clippy = "Broken"
clippy = "Compiling"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it intended it is changed to Compiling not Testing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea, testing wasn't allowed until a few hours ago: rust-dev-tools/dev-tools-team#18 (comment)

I'll rebase to fix the failure and enable testing

@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 9, 2017
@oli-obk oli-obk force-pushed the clippy branch 2 times, most recently from 0d3b45c to 7ac1661 Compare November 14, 2017 14:53
@oli-obk
Copy link
Contributor Author

oli-obk commented Nov 14, 2017

Clippy can now be tested. There are some weird issues with compiletest, but I'm thinking we can probably rig rustc's compiletest to run the tests instead

@kennytm
Copy link
Member

kennytm commented Nov 14, 2017

@bors r+ p=1

@bors
Copy link
Contributor

bors commented Nov 14, 2017

📌 Commit 7ac1661 has been approved by kennytm

@kennytm kennytm added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Nov 14, 2017
@bors
Copy link
Contributor

bors commented Nov 14, 2017

⌛ Testing commit 7ac16617196bd1c559fcd9cedb5d1ac6fd53d444 with merge 0cfcf422335ba6628b757b3bc4776b4454e872d4...

@bors
Copy link
Contributor

bors commented Nov 15, 2017

💔 Test failed - status-travis

@kennytm
Copy link
Member

kennytm commented Nov 15, 2017

Sorry clippy needs to be updated again 😞

[01:23:56]    Compiling clippy_lints v0.0.170 (file:///Users/travis/build/rust-lang/rust/src/tools/clippy/clippy_lints)
[01:23:58] error[E0432]: unresolved import `rustc::mir::transform`
[01:23:58]   --> src/tools/clippy/clippy_lints/src/utils/mod.rs:12:17
[01:23:58]    |
[01:23:58] 12 | use rustc::mir::transform::MirSource;
[01:23:58]    |                 ^^^^^^^^^ Could not find `transform` in `mir`
[01:23:58] 
[01:24:02] error[E0432]: unresolved import `rustc::mir::transform`
[01:24:02]   --> src/tools/clippy/clippy_lints/src/utils/mod.rs:12:17
[01:24:02]    |
[01:24:02] 12 | use rustc::mir::transform::MirSource;
[01:24:02]    |                 ^^^^^^^^^ Could not find `transform` in `mir`
[01:24:02] 
[01:24:02] error: aborting due to previous error
[01:24:02] 
[01:24:02] error: Could not compile `clippy_lints`.
[01:24:02] warning: build failed, waiting for other jobs to finish...
[01:24:06] error: aborting due to previous error
[01:24:06] 
[01:24:06] error: Could not compile `clippy_lints`.

@kennytm kennytm added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 15, 2017
@kennytm
Copy link
Member

kennytm commented Nov 15, 2017

@bors r+

@bors
Copy link
Contributor

bors commented Nov 15, 2017

📌 Commit 5319203 has been approved by kennytm

@bors
Copy link
Contributor

bors commented Nov 15, 2017

⌛ Testing commit 5319203 with merge 7589147...

bors added a commit that referenced this pull request Nov 15, 2017
@bors
Copy link
Contributor

bors commented Nov 15, 2017

💔 Test failed - status-travis

@kennytm
Copy link
Member

kennytm commented Nov 15, 2017

@bors retry #42117

Corrupted submodule??

[00:03:45] fatal: packed object 5b3f5468043e7ab6883fa7683e795aadf311017f (stored in /Users/travis/rustsrc/src/.git/modules/src/doc/nomicon/objects/pack/pack-8b46ddbde06b2411f3957d8dade78fe90ec97c01.pack) is corrupt
[00:03:45] Submodule path 'src/doc/reference': checked out '36adc6ae504c6e0343ab5d7b3871f0a2a71236da'
[00:03:46] Submodule path 'src/jemalloc': checked out '1f5a28755e301ac581e2048011e4e0ff3da482ef'
[00:03:46] Submodule path 'src/libcompiler_builtins': checked out '0b9844764ea1f99ea11a7917a4f3ba7fd2db775c'
[00:03:46] Submodule path 'src/liblibc': checked out 'c1068cd82ae55907e8fd4457b98278a3aaa9162b'
[00:03:46] Submodule path 'src/rt/hoedown': checked out 'da282f1bb7277b4d30fa1599ee29ad8eb4dd2a92'
[00:03:47] Submodule path 'src/tools/cargo': checked out 'abd137ad14a8f352b48f24b11c3995d716deb260'
[00:03:49] Submodule path 'src/tools/clippy': checked out 'f76225e3887170743403af9204887918b5db5a80'
[00:03:51] Submodule path 'src/tools/miri': checked out '80853e2f24a01db96fe9821e468dd2af75a4d2e5'
[00:03:51] Submodule path 'src/tools/rls': checked out '015073b7c8a192584c15b2c1bd34a92025cf6836'
[00:03:51] Submodule path 'src/tools/rust-installer': checked out '0ddd53c4bc2a76df565a1c1fc0cc6f19f254b51e'
[00:03:54] Submodule path 'src/tools/rustfmt': checked out '291dbe8d87701f3617ccdd70caa49df1c27af0e0'
[00:03:54] Unable to checkout '1625e0b8c870891b84b0969777a974bf87be579b' in submodule path 'src/doc/nomicon'

@bors
Copy link
Contributor

bors commented Nov 15, 2017

⌛ Testing commit 5319203 with merge ce2b8a4...

bors added a commit that referenced this pull request Nov 15, 2017
@bors
Copy link
Contributor

bors commented Nov 15, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: kennytm
Pushing ce2b8a4 to master...

@bors bors merged commit 5319203 into rust-lang:master Nov 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Compile error: clippy_lints does not support feature(macro_vis_matcher)
3 participants