New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

List of all lang items in unstable book. #45181

Merged

alexcrichton merged 1 commit into rust-lang:master from Havvy:doc-unstable-lang-items

Oct 18, 2017

Contributor

Havvy commented Oct 10, 2017

I don't know how to link to the source code correctly, so I just put the information aside the lang item name.

rust-highfive assigned QuietMisdreavus

Collaborator

rust-highfive commented Oct 10, 2017

r? @QuietMisdreavus

(rust_highfive has picked a reviewer for you, use r? to override)

Havvy mentioned this pull request

Include a list of all built-in language items rust-lang/reference#117

Closed

Member

QuietMisdreavus commented Oct 10, 2017

cc @rust-lang/docs

I'm 👍 👍 👍 about having this list in here. I'm not sure about the presentation, though - it would be cool to have at least an intro statement saying that this is the list and where to find each definition. Adding a proper description to each item would be ideal, but possibly out of scope to just getting the list in there in the first place.

Also, is there some way to have tidy check for this? I don't think adding lang items is nearly as widespread as adding features (if it's even done any more), but if it were, it would be cool to make sure they were listed here. It would also help to somewhat automate putting the right source file in there, to make sure the docs don't diverge too much. I don't remember who was responsible for the current tidy unstable-book check - @steveklabnik was that you, or do you know?

Member

GuillaumeGomez commented Oct 11, 2017

It's a bit difficult to find what we're looking for. Maybe sort alphabetically?

aidanhs added the S-waiting-on-review label

Havvy force-pushed the doc-unstable-lang-items branch from f8bf0fd to ed68508 Compare

October 13, 2017 00:32

Contributor Author

Havvy commented Oct 13, 2017 •

edited

Loading

I've rebased with @QuietMisdreavus's requested change w.r.t. a sentence describing what the list is.

For @GuillaumeGomez's suggestion, I don't think fully alphabetical is useful. Instead, I put them in each sections. I guess I could have alphabetized each section though...I'll do that if I have to do some other change.

Really, this list is supposed to be a springboard for people actually documenting what each lang item is (and can easily be turned into a tracking issue) at some point in the future; probably after the impl period? So I'd like to just get it in there for now, and not be perfect.

tshepang reviewed

View reviewed changes

src/doc/unstable-book/src/language-features/lang-items.md Outdated

    
                - const_ptr: libcore/ptr.rs

                - mut_ptr: libcore/ptr.rs

                - unsafe_cell: libcore/cell.rs

              - Rutime

Member

tshepang Oct 15, 2017

should be Runtime

kennytm added S-waiting-on-author and removed S-waiting-on-review labels

Havvy force-pushed the doc-unstable-lang-items branch from ed68508 to 64e9d8a Compare

October 15, 2017 16:30

QuietMisdreavus reviewed

View reviewed changes

Member

QuietMisdreavus left a comment

Could you wrap the lang-item names and the paths in backticks, just so we don't have errant underscores mangling the output?
I kinda feel like coerce_unsized belongs more with the "Other" items rather than with the rest of the operators, since it's not really describing an operator in the same way as index or bitxor, but a behavior. (It just happens to be defined alongside the rest of the operators. >_>)

src/doc/unstable-book/src/language-features/lang-items.md Outdated

    
            @@ -99,7 +99,7 @@ libc = { version = "0.2.14", default-features = false }
          
              ```

              Note that the default features have been disabled. This is a critical step -

              **the default features of libc include the standard library and so must be

              - -*the default features of libc include the standard library and so must be

Member

QuietMisdreavus Oct 16, 2017

Looks like a misplaced change here?

src/doc/unstable-book/src/language-features/lang-items.md Outdated

    
                - eh_personality: libpanic_unwind/seh.rs (SEH)

                - eh_unwind_resume: libpanic_unwind/seh64_gnu.rs (SEH64 GNU)

                - eh_unwind_resume: libpanic_unwind/gcc.rs (GCC)

                - msvc_try_filter": libpanic_unwind/seh.rs (SEH)

Member

QuietMisdreavus Oct 16, 2017

Errant quote?

Havvy force-pushed the doc-unstable-lang-items branch from 64e9d8a to 09ea371 Compare

October 16, 2017 22:04

QuietMisdreavus reviewed

View reviewed changes

Member

QuietMisdreavus left a comment

Gets a 👍 from me with this, though I'd like to wait on @steveklabnik and @frewsxcv to make sure the whole docs team sees it before giving an r+.

src/doc/unstable-book/src/language-features/lang-items.md Outdated

    
              - Runtime

                - `start`: `libstd/rt.rs`

                - `eh_personality`: `libpanic_unwind/emcc.rs (EMCC)`

                - `eh_personality`: `libpanic_unwind/seh64_gnu.rs (SEH64 GNU)`

Member

QuietMisdreavus Oct 16, 2017

I guess these platform markers should go outside the backticks for the filename.

Contributor Author

Havvy Oct 16, 2017

Yes....

Havvy force-pushed the doc-unstable-lang-items branch from 09ea371 to 0193595 Compare

October 16, 2017 23:02

kennytm added S-waiting-on-review and removed S-waiting-on-author labels

frewsxcv approved these changes

View reviewed changes

Member

frewsxcv left a comment

minus my comments, looks great to me!

src/doc/unstable-book/src/language-features/lang-items.md Outdated

    
                - `i128`: `libcore/num/mod.rs`

                - `isize`: `libcore/num/mod.rs`

                - `isize`: `libcore/num/mod.rs`

                - `isize`: `libcore/num/mod.rs`

Member

frewsxcv Oct 17, 2017

looks like isize is repeated (same with usize below)

Contributor Author

Havvy Oct 17, 2017

How did I not see that? (It's defined once for each configuration of pointer size.)

kennytm added S-waiting-on-author and removed S-waiting-on-review labels


          List of all lang items in unstable book.

Havvy force-pushed the doc-unstable-lang-items branch from 0193595 to 1287300 Compare

October 17, 2017 14:47

Member

frewsxcv commented Oct 18, 2017

thanks!

@bors r+ rollup

Contributor

bors commented Oct 18, 2017

📌 Commit 1287300 has been approved by frewsxcv

kennytm added S-waiting-on-bors and removed S-waiting-on-author labels

kennytm added a commit to kennytm/rust that referenced this pull request


          Rollup merge of rust-lang#45181 - Havvy:doc-unstable-lang-items, r=fr…

61c58c1

…ewsxcv

List of all lang items in unstable book.

I don't know how to link to the source code correctly, so I just put the information aside the lang item name.

kennytm mentioned this pull request

Rollup of 10 pull requests #45368

Merged

bors added a commit that referenced this pull request


          Auto merge of #45368 - kennytm:rollup, r=kennytm

b796087

Rollup of 10 pull requests

- Successful merges: #44138, #45082, #45098, #45181, #45217, #45281, #45325, #45326, #45340, #45354
- Failed merges:

alexcrichton merged commit 1287300 into rust-lang:master

Havvy deleted the doc-unstable-lang-items branch

October 19, 2017 00:21

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

S-waiting-on-bors