Update let-expressions.rs with DepNode labels #45148
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| #[rustc_clean(label="MirValidated", cfg="cfail3")] | ||
| #[rustc_dirty(label="MirOptimized", cfg="cfail2")] | ||
| #[rustc_clean(label="MirOptimized", cfg="cfail3")] | ||
| #[rustc_clean(label="TypeckTables", cfg="cfail2")] |
There was a problem hiding this comment.
@michaelwoerister isn't it a bit surprising that TypeckTables is clean here? (Am I correct to interpret clean as green?)
There was a problem hiding this comment.
Oh, I guess it's just that the name of the variable doesn't show up in there.
There was a problem hiding this comment.
Yes, it is surprising but it's valid, I think.
nikomatsakis
approved these changes
Oct 10, 2017
|
@bors r+ rollup |
|
📌 Commit 29b576e has been approved by |
steveklabnik
added a commit
to steveklabnik/rust
that referenced
this pull request
Oct 11, 2017
Update let-expressions.rs with DepNode labels As a part of rust-lang#44924, the PR has tests verified for the following dependency nodes for **let-expressions** ``` - MirValidated - MirOptimized - TypeCheckTables - TypeOfItem - GenericsOfItem - PredicatesOfItem - FnSignature ``` As we are more concerned with the function body, the following fingerprints do not change over compilation sessions. ```- TypeOfItem - GenericsOfItem - PredicatesOfItem - FnSignature ``` r? @nikomatsakis cc @michaelwoerister P.S. Will add more tests as and when possible :)
shepmaster
added
the
S-waiting-on-bors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As a part of #44924, the PR has tests verified for the following dependency nodes for let-expressions
As we are more concerned with the function body, the following fingerprints do not change over compilation sessions.
r? @nikomatsakis
cc @michaelwoerister
P.S. Will add more tests as and when possible :)