Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring: move net specific file descriptor methods #43900

Merged
merged 1 commit into from
Aug 18, 2017

Conversation

TobiasSchaffner
Copy link

Move the implementations of net specific file descriptor methods from
io to net. This makes it easier to exclude net at all if it is not needed
for a target.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @BurntSushi (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

Move the implementations of net specific file descriptior implementations
to net. This makes it easier to exclude net at all if not needed for a
target.
@alexcrichton
Copy link
Member

@bors: r+

Thanks!

@bors
Copy link
Contributor

bors commented Aug 16, 2017

📌 Commit 2ccaeff has been approved by alexcrichton

@aidanhs aidanhs added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Aug 16, 2017
@bors
Copy link
Contributor

bors commented Aug 17, 2017

⌛ Testing commit 2ccaeff with merge c13aea02549e8e4f4aaad3ed62d6fa6c2866affc...

@bors
Copy link
Contributor

bors commented Aug 17, 2017

💔 Test failed - status-travis

@kennytm
Copy link
Member

kennytm commented Aug 17, 2017

@bors retry

#43283 on arm-android.

[01:09:26] thread '<unnamed>' panicked at 'other was less than the current instant', /checkout/src/libstd/sys/unix/time.rs:276:16
[01:09:31] test sync::mpsc::tests::stress_recv_timeout_two_threads ... ok
[01:09:34] test collections::hash::map::test_map::test_lots_of_insertions ... ok
[01:09:57] test process::tests::test_process_output_fail_to_start has been running for over 60 seconds


No output has been received in the last 30m0s, this potentially indicates a stalled build or something wrong with the build itself.

@bors
Copy link
Contributor

bors commented Aug 17, 2017

⌛ Testing commit 2ccaeff with merge 85cdc54543978fffd351644a571e59b4ff0fb0c1...

@kennytm
Copy link
Member

kennytm commented Aug 17, 2017

@bors retry

The macOS 64-bit dist job stuck at the "Job received" stage for over 3 hours and never start.

@kennytm
Copy link
Member

kennytm commented Aug 17, 2017

https://travis-ci.org/rust-lang/rust/builds/265581807 (not editing to prevent sending a bors command)

Problem on Travis side probably caused by the recent update https://www.traviscistatus.com/incidents/kdvnlc4w3n67.

cc #40672

@bors
Copy link
Contributor

bors commented Aug 18, 2017

⌛ Testing commit 2ccaeff with merge 8016eea...

bors added a commit that referenced this pull request Aug 18, 2017
Refactoring: move net specific file descriptor methods

Move the implementations of net specific file descriptor methods from
io to net. This makes it easier to exclude net at all if it is not needed
for a target.
@bors
Copy link
Contributor

bors commented Aug 18, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: alexcrichton
Pushing 8016eea to master...

@bors bors merged commit 2ccaeff into rust-lang:master Aug 18, 2017
@TobiasSchaffner TobiasSchaffner deleted the net_out_of_io branch August 18, 2017 10:24
@TobiasSchaffner TobiasSchaffner restored the net_out_of_io branch August 18, 2017 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants