Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing E0623 error message - both anonymous lifetime regions #43541

Merged
merged 1 commit into from
Jul 29, 2017

Conversation

gaurikholkar-zz
Copy link

Changing the error message to

error[E0623]: lifetime mismatch
  --> $DIR/ex3-both-anon-regions.rs:12:12
   |
11 | fn foo(x: &mut Vec<&u8>, y: &u8) {
   |                    ---      --- these references are not declared with the same lifetime...
12 |     x.push(y);
   |            ^ ...but data from `y` flows into `x` here

error: aborting due to previous error

cc @nikomatsakis @aturon @jonathandturner

r? @nikomatsakis

@nikomatsakis
Copy link
Contributor

@bors r+

Seems like an improvement. But then I proposed it. 👅

@bors
Copy link
Contributor

bors commented Jul 29, 2017

📌 Commit cb93cc6 has been approved by nikomatsakis

@bors
Copy link
Contributor

bors commented Jul 29, 2017

⌛ Testing commit cb93cc6 with merge 47b9723362247f8ccd5a448ee169ecdb12adc929...

@bors
Copy link
Contributor

bors commented Jul 29, 2017

⌛ Testing commit cb93cc6 with merge cfe1668...

bors added a commit that referenced this pull request Jul 29, 2017
Changing E0623 error message - both anonymous lifetime regions

Changing the error message to
```
error[E0623]: lifetime mismatch
  --> $DIR/ex3-both-anon-regions.rs:12:12
   |
11 | fn foo(x: &mut Vec<&u8>, y: &u8) {
   |                    ---      --- these references are not declared with the same lifetime...
12 |     x.push(y);
   |            ^ ...but data from `y` flows into `x` here

error: aborting due to previous error
```
cc @nikomatsakis @aturon @jonathandturner

r? @nikomatsakis
@bors
Copy link
Contributor

bors commented Jul 29, 2017

☀️ Test successful - status-appveyor, status-travis
Approved by: nikomatsakis
Pushing cfe1668 to master...

@bors bors merged commit cb93cc6 into rust-lang:master Jul 29, 2017
@kennytm
Copy link
Member

kennytm commented Jul 31, 2017

@bors p=-2 (unblock bors)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants