Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rework Rustbuild to an eagerly compiling approach #43059

Merged
merged 51 commits into from
Jul 22, 2017
Merged

Rework Rustbuild to an eagerly compiling approach #43059

merged 51 commits into from
Jul 22, 2017

Commits on Jul 20, 2017

  1. Move rule configs out of step

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    0a1b5e8 View commit details
    Browse the repository at this point in the history

  2. Move code into Step trait implementations. 

    No changes are introduced to code body. This commit will not build; it
is done to permit a better diff in later commits.
    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    001e9f3 View commit details
    Browse the repository at this point in the history

  3. Change code to work with the new system

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    6b3413d View commit details
    Browse the repository at this point in the history

  4. Add Builder and Step definitions.

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    cd3dd80 View commit details
    Browse the repository at this point in the history

  5. Fixes warnings and errors introduced while moving code around

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    6038830 View commit details
    Browse the repository at this point in the history

  6. Move tool_cmd to tool.rs

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    1a844eb View commit details
    Browse the repository at this point in the history

  7. Fix tool_cmd

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    276090e View commit details
    Browse the repository at this point in the history

  8. Move cargo() to Builder

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    7db49fb View commit details
    Browse the repository at this point in the history

  9. Finish fixing warnings and errors. Bootstrap builds.

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    c114fe5 View commit details
    Browse the repository at this point in the history

  10. Move code out of macro and into generic method.

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    ef1d1bd View commit details
    Browse the repository at this point in the history

  11. Pacify tidy

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    e62fdf3 View commit details
    Browse the repository at this point in the history

  12. Add documentation to Step and related methods on Builder.

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    8264e42 View commit details
    Browse the repository at this point in the history

  13. Document the process more thoroughly

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    b881aae View commit details
    Browse the repository at this point in the history

  14. Move compiletest config into a struct

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    1ab8930 View commit details
    Browse the repository at this point in the history

  15. Rework compiletest implementation.

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    aa8b93b View commit details
    Browse the repository at this point in the history

  16. Fix a nit.

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    d812d43 View commit details
    Browse the repository at this point in the history

  17. Migrate to serde_json entirely

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    d360af4 View commit details
    Browse the repository at this point in the history

  18. Update to toml 0.4

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    a1fa268 View commit details
    Browse the repository at this point in the history

  19. Cherry pick changes from ce3abc5. 

    Fix stage 2 builds with a custom libdir.

When copying libstd for the stage 2 compiler, the builder ignores the
configured libdir/libdir_relative configuration parameters.  This causes
the compiler to fail to find libstd, which cause any tools built with the
stage 2 compiler to fail.

To fix this, make the copy steps of rustbuild aware of the libdir_relative
parameter when the stage >= 2.  Also update the dist target to be aware of
the new location of libstd.
    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    c7435b5 View commit details
    Browse the repository at this point in the history

  20. Fix a few errors introduced during rebase.

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    a5ab2ce View commit details
    Browse the repository at this point in the history

  21. Fix more incorrectly transitioned code

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    ceecd62 View commit details
    Browse the repository at this point in the history

  22. Cleanups and fixes throughout

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    5984e70 View commit details
    Browse the repository at this point in the history

  23. Clean up install

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    6a85193 View commit details
    Browse the repository at this point in the history

  24. Remove core_intrinsics feature gate

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    e7b1a60 View commit details
    Browse the repository at this point in the history

  25. Utilize interning to allow Copy/Clone steps

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    528646e View commit details
    Browse the repository at this point in the history

  26. Make the book default.

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    270d1d6 View commit details
    Browse the repository at this point in the history

  27. Require should_run to be implemented.

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    681b123 View commit details
    Browse the repository at this point in the history

  28. Implement keep-stage support

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    fc3d06a View commit details
    Browse the repository at this point in the history

  29. Remove outdated FIXME from cache

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    17f4b8f View commit details
    Browse the repository at this point in the history

  30. Fix tidy

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    f19728f View commit details
    Browse the repository at this point in the history

  31. fail in case nothing to run was found

    @GuillaumeGomez @Mark-Simulacrum
    GuillaumeGomez authored and Mark-Simulacrum committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    828b661 View commit details
    Browse the repository at this point in the history

  32. Resolve rebase errors

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    dec44b0 View commit details
    Browse the repository at this point in the history

  33. Remove deserialize

    @aidanhs @Mark-Simulacrum
    aidanhs authored and Mark-Simulacrum committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    28defe0 View commit details
    Browse the repository at this point in the history

  34. Remove TypeId from stack in Builder

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    7414868 View commit details
    Browse the repository at this point in the history

  35. Remove outdated code. 

    Relevant sys crates handle this properly.
    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    ba1fc82 View commit details
    Browse the repository at this point in the history

  36. Krate -> Crate

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    981afa5 View commit details
    Browse the repository at this point in the history

  37. Use a single line for serde annotations.

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    bca1e2f View commit details
    Browse the repository at this point in the history

  38. Implement available paths list.

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    56128fb View commit details
    Browse the repository at this point in the history

  39. Allow iterating over step descriptions. 

    This simplifies code and allows working mostly with normal Rust instead
of macros.
    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    5bdec80 View commit details
    Browse the repository at this point in the history

  40. Fix a few issues found by comparing past/present

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    4a21c72 View commit details
    Browse the repository at this point in the history

  41. Don't run host-only tests when targeting another platform

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    f1d04a3 View commit details
    Browse the repository at this point in the history

  42. Don't include lldb/gdb in default tests

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    951616c View commit details
    Browse the repository at this point in the history

  43. Change default documentation rules to correspond with previous state.

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    bcd73c9 View commit details
    Browse the repository at this point in the history

  44. Check RLS tests

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    8563280 View commit details
    Browse the repository at this point in the history

  45. Remove step.rs comments

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    e9c2242 View commit details
    Browse the repository at this point in the history

  46. Remove step.rs

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    d8aecc1 View commit details
    Browse the repository at this point in the history

  47. Add an optional condition to constrain defaults. 

    Utilized primarily to not be a default rule unless some configuration is
given (e.g., compiler docs are enabled).
    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    b05af49 View commit details
    Browse the repository at this point in the history

  48. Change make_run signature to taking a RunConfig struct for refactorab… 

    …ility.
    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 20, 2017
    Configuration menu
    Copy the full SHA
    6a67a05 View commit details
    Browse the repository at this point in the history

Commits on Jul 22, 2017

  1. Fix StartupObject build

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 22, 2017
    Configuration menu
    Copy the full SHA
    d302c18 View commit details
    Browse the repository at this point in the history

  2. Add make_run to distcheck.

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 22, 2017
    Configuration menu
    Copy the full SHA
    8f2e576 View commit details
    Browse the repository at this point in the history

  3. Make distcheck work again.

    @Mark-Simulacrum
    Mark-Simulacrum committed Jul 22, 2017
    Configuration menu
    Copy the full SHA
    1c11823 View commit details
    Browse the repository at this point in the history