-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[libstd_unicode] Upgrade to Unicode 10.0.0 #42999
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
|
@jonas-schievink, I ran the script to generate the file. I didn't mention that part because I thought it's obvious. In #42998, I applied the change manually, because running the script also causes these changes. So, we can apply #42998 after this one, hopefully, to avoid breaking any instructions, theoretically. |
CC'ing from file's blame/history: @petrochenkov, @cuviper, @alexcrichton, @SimonSapin |
Oh, nevermind then, I thought you'd have to do some changes to the script itself. |
Yeah, the script always fetches the So, is there any reason to keep it as it is, or can I send a PR? |
r? @alexcrichton -- I think this falls more into libs |
📌 Commit a6994d7 has been approved by |
[libstd_unicode] Upgrade to Unicode 10.0.0 Update `libstd_unicode`'s data tables to Unicode 10.0.0, as released on 2017 June 20: http://www.unicode.org/versions/Unicode10.0.0/
☀️ Test successful - status-appveyor, status-travis |
Could you please check rust-lang/regex#391 as well. The |
See rust-lang/regex#400 for Unicode 10.0. |
@cuviper Awesome! |
Update
libstd_unicode
's data tables to Unicode 10.0.0, as released on 2017 June 20: http://www.unicode.org/versions/Unicode10.0.0/