Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[libstd_unicode] Change UNICODE_VERSION to use u32 #42998

Merged
merged 2 commits into from
Aug 8, 2017
Merged

[libstd_unicode] Change UNICODE_VERSION to use u32 #42998

merged 2 commits into from
Aug 8, 2017

Commits on Jul 21, 2017

  1. [libstd_unicode] Change UNICODE_VERSION to use u32 

    Use `u32` for version components, as `u64` is just an overkill, and
`u32` is the default type for integers and the default type used for
regular internal numbers.

There's no expectation for Unicode Versions to even reach one thousand
in the next hundered years. This is different from *package versions*,
which may become something auto-generated and exceed human-friendly
range of integer values.
    @behnam
    behnam committed Jul 21, 2017
    Configuration menu
    Copy the full SHA
    7ebb6ee View commit details
    Browse the repository at this point in the history

  2. [libstd_unicode] Create UnicodeVersion type 

    Create named struct `UnicodeVersion` to use instead of tuple type for
`UNICODE_VERSION` value. This allows user to access the fields with
meaningful field names: `major`, `minor`, and `micro`.

Per request, an empty private field is added to the struct, so it can be
extended in the future without API breakage.
    @behnam
    behnam committed Jul 21, 2017
    Configuration menu
    Copy the full SHA
    42f8861 View commit details
    Browse the repository at this point in the history