Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #42185

Closed
wants to merge 25 commits into from
Closed

Rollup of 8 pull requests #42185

wants to merge 25 commits into from

Conversation

ishitatsuyuki and others added 25 commits May 20, 2017 14:06
This was breaking the libstd build for Redox.
Also, improve the split mechanism to address space in paths.
only create source tarball for the Dist subcommand
mark install rule as default for Kind::Install
split install-docs
split install-std
factor out empty_dir handling
split install-cargo
split install-analysis
split install-src
rework install-rustc
properly handle cross-compilation setups for install
use pkgname in install
split plain source tarball generation from rust-src dist
document src-tarball in config.toml.exmaple

Signed-off-by: Marc-Antoine Perennou <[email protected]>
iterator_step_by has decoupled their futures, so the tracking issue should split.
Signed-off-by: Marc-Antoine Perennou <[email protected]>
Also, add detection to treat such comments as tidy errors.
We also remove the found_lib_feature code because it
was just repeating the found_feature code. Originally it
was intended to allow for gate-test lines for
lib features, but apparently nobody missed it.
…idanhs

Use the improved submodule handling

r? @alexcrichton

That was a crap...
```
Updating submodules
Traceback (most recent call last):
  File "./x.py", line 20, in <module>
    bootstrap.main()
  File "/home/ishitatsuyuki/Documents/rust/src/bootstrap/bootstrap.py", line 684, in main
    bootstrap()
  File "/home/ishitatsuyuki/Documents/rust/src/bootstrap/bootstrap.py", line 662, in bootstrap
    rb.update_submodules()
  File "/home/ishitatsuyuki/Documents/rust/src/bootstrap/bootstrap.py", line 566, in update_submodules
    path = line[1:].split(' ')[1]
TypeError: a bytes-like object is required, not 'str'
```

Maybe we need to confirm the compatibility of git options, such as `git config` or `git -C` (I believe they existed long before, though). This is tested locally.
rustbuild: don't create a source tarball when installing

This splits Install out of Dist as it is not a full dist anymore, and creates the source tarball only for the Dist command.
This will allow splitting install in a few rules if we want as it's done for other phases.
remove "much" from unicode diagnostic

The English seems slightly awkward to me, and it's unnecessary.
Fix building std without backtrace feature, which was broken in ca8b754

Fixes rust-lang#42139
Implement requires_synchronized_create() for Redox

This was breaking the libstd build for Redox.
Document drop more.

Adds two examples to Drop and describes the recursive drop on types that contain fields.
…excrichton

Give step_trait a distinct tracking issue from step_by

iterator_step_by has decoupled their futures, so the tracking issue should split.

Old issue: rust-lang#27741
New issue: rust-lang#42168

r? @alexcrichton (another follow-up to closed PR rust-lang#42110 (comment))
Remove some needless // gate-test- comments

Also, add detection to treat such comments as tidy errors.
We also remove the found_lib_feature code because it
was just repeating the found_feature code. Originally it
was intended to allow for gate-test lines for
lib features, but apparently nobody missed it.
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @nikomatsakis (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@frewsxcv
Copy link
Member Author

@bors r+ p=10

@bors
Copy link
Contributor

bors commented May 24, 2017

📌 Commit 308cbf3 has been approved by frewsxcv

@bors
Copy link
Contributor

bors commented May 24, 2017

⌛ Testing commit 308cbf3 with merge 7024008...

@bors
Copy link
Contributor

bors commented May 24, 2017

💔 Test failed - status-travis

@kennytm
Copy link
Member

kennytm commented May 24, 2017

Dist-check failed (#42109)

[01:31:30] Distcheck rust-src
[01:31:30] tar (child): /checkout/obj/build/dist/rust-src-1.19.0-dev.tar.gz: Cannot open: No such file or directory
[01:31:30] tar (child): Error is not recoverable: exiting now
[01:31:30] tar: Child returned status 2
[01:31:30] 
[01:31:30] tar: Error is not recoverable: exiting now
[01:31:30] 
[01:31:30] command did not execute successfully: "tar" "-xzf" "/checkout/obj/build/dist/rust-src-1.19.0-dev.tar.gz" "--strip-components=1"
[01:31:30] expected success, got: exit code: 2
[01:31:30] 
[01:31:30] 
[01:31:30] Build completed unsuccessfully in 1:30:14

@Centril Centril added the rollup A PR which is a rollup label Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup
Projects
None yet
Development

Successfully merging this pull request may close these issues.