Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustdoc: Break words in the location box of the sidebar. #41951

Merged
merged 1 commit into from
May 13, 2017

Conversation

Eijebong
Copy link
Contributor

This prevents long names from overflowing.

Before:
before

After:
after

This prevents long names from overflowing.
@rust-highfive
Copy link
Collaborator

Some changes occurred in HTML/CSS.

cc @GuillaumeGomez

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @frewsxcv (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@shepmaster
Copy link
Member

Thanks for the PR! We'll get @GuillaumeGomez or @frewsxcv to check it out in a reasonable amount of time!

@shepmaster shepmaster added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 12, 2017
@GuillaumeGomez
Copy link
Member

Nothing to say, thanks for the PR! (I tested with normal items, still good.)

@bors: r+ rollup

@bors
Copy link
Contributor

bors commented May 12, 2017

📌 Commit 26e7e49 has been approved by GuillaumeGomez

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request May 13, 2017
rustdoc: Break words in the location box of the sidebar.

This prevents long names from overflowing.

Before:
![before](https://img.bananium.fr/eijebong/afcfe18b-393e-4d3b-bc11-fe3def6659b9.png)

After:
![after](https://img.bananium.fr/eijebong/9483466b-3b6c-4509-ab0f-fd0c6572ef27.png)
bors added a commit that referenced this pull request May 13, 2017
@bors bors merged commit 26e7e49 into rust-lang:master May 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants