-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
On demandify region mapping #41662
Merged
bors
merged 11 commits into
rust-lang:master
from
nikomatsakis:on-demandify-region-mapping
May 2, 2017
Merged
On demandify region mapping #41662
bors
merged 11 commits into
rust-lang:master
from
nikomatsakis:on-demandify-region-mapping
May 2, 2017
Commits on Apr 30, 2017
-
Configuration menu - View commit details
-
Copy full SHA for eff39b7 - Browse repository at this point
Copy the full SHA eff39b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for 119c38e - Browse repository at this point
Copy the full SHA 119c38eView commit details -
remove ROOT_CODE_EXTENT and DUMMY_CODE_EXTENT
Instead, thread around `Option<CodeExtent>` where applicable.
Configuration menu - View commit details
-
Copy full SHA for 55d6066 - Browse repository at this point
Copy the full SHA 55d6066View commit details -
Make a `CodeExtent<'tcx>` be something allocated in an arena instead of an index into the `RegionMaps`.
Configuration menu - View commit details
-
Copy full SHA for c7dc39d - Browse repository at this point
Copy the full SHA c7dc39dView commit details -
Instead of requesting the region maps for the entire crate, request for a given item etc. Several bits of code were modified to take `&RegionMaps` as input (e.g., the `resolve_regions_and_report_errors()` function). I am not totally happy with this setup -- I *think* I'd rather have the region maps be part of typeck tables -- but at least the `RegionMaps` works in a "parallel" way to `FreeRegionMap`, so it's not too bad. Given that I expect a lot of this code to go away with NLL, I didn't want to invest *too* much energy tweaking it.
Configuration menu - View commit details
-
Copy full SHA for 73cd9bd - Browse repository at this point
Copy the full SHA 73cd9bdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 6c2f64b - Browse repository at this point
Copy the full SHA 6c2f64bView commit details
Commits on May 1, 2017
-
Configuration menu - View commit details
-
Copy full SHA for d4d74da - Browse repository at this point
Copy the full SHA d4d74daView commit details -
Configuration menu - View commit details
-
Copy full SHA for c0434e2 - Browse repository at this point
Copy the full SHA c0434e2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3438cda - Browse repository at this point
Copy the full SHA 3438cdaView commit details -
kill regr test using ad-hoc lint
This was a pretty narrow test to start with, and it's kind of a pain to update it. Not worth the trouble IMO.
Configuration menu - View commit details
-
Copy full SHA for b393d64 - Browse repository at this point
Copy the full SHA b393d64View commit details
Commits on May 2, 2017
-
Configuration menu - View commit details
-
Copy full SHA for c008f05 - Browse repository at this point
Copy the full SHA c008f05View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.