Remove non-breaking spaces from natvis files #41344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
Thank you for fixing this! I was wondering why they weren't working in VS. |
|
@AndrewGaspar Thanks for adding them - they work well except I don't think |
|
@bors: r+ |
|
📌 Commit 1528cbe has been approved by |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 18, 2017
…richton Remove non-breaking spaces from natvis files Visual studio will see natvis files with non-breaking spaces as invalid XML, and will ignore them.
|
☔ The latest upstream changes (presumably #41357) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Visual studio will see natvis files with non-breaking spaces as invalid XML, and will ignore them.