-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rename serialization to encodement #4125
Conversation
+1, suggest possibly exploiting the natural word stem here and going with (That is to say, I concur that |
Good idea. I've renamed this to |
'serialization' makes more sense to me. 'code' doesn't suggest what the module is for. |
@brson how about naming the module I'm just concerned with the -izable and -ization suffixes. Very chatty. |
I like |
@brson: do you also prefer serial::Serializer over serial::Encoder as well? |
FWIW, when I hear It seems that the intention of this pull request is to rename the module for the sake of less typing (which is understandable) but making it less clear in the process what the module actually does. Is that really worth it? Not intending to walk all over your work @erickt, I'm just wondering if it's really a good direction to go. :) |
FWIW Go uses |
@alexrp: Not a problem. I'm not crazy about |
@erickt I do prefer Serializer over Encoder, but not a strong preference. |
Merged in (finally!), closing. |
This implements #3713.
Serializable
andDeserializable
is quite wordy, whereasEncodable
andDecodable
is much more pleasant.std::encodement
is also little wordy though. Wouldstd::encoder
be better?Also, this will require another 2 snapshot shuffle. One for the first commit, then one before we remove the old
serialization.rs
.