Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rename serialization to encodement #4125

Closed
wants to merge 3 commits into from

Conversation

erickt
Copy link
Contributor

@erickt erickt commented Dec 6, 2012

This implements #3713. Serializable and Deserializable is quite wordy, whereas Encodable and Decodable is much more pleasant. std::encodement is also little wordy though. Would std::encoder be better?

Also, this will require another 2 snapshot shuffle. One for the first commit, then one before we remove the old serialization.rs.

@graydon
Copy link
Contributor

graydon commented Dec 7, 2012

+1, suggest possibly exploiting the natural word stem here and going with std::coding, with Encodable, Decodable, Encoder,Decoder, thenCodable : Encodable, DecodableandCoder : Encoder, Decoder`?

(That is to say, I concur that encodement is not a good word, and you should at least pick std::encoder or std::encoding or std::encode. But that's asymmetric, so I suggested just std::coding, or even std::code?)

@erickt
Copy link
Contributor Author

erickt commented Dec 7, 2012

Good idea. I've renamed this to std::code and updated the pull request.

@brson
Copy link
Contributor

brson commented Dec 7, 2012

'serialization' makes more sense to me. 'code' doesn't suggest what the module is for.

@graydon
Copy link
Contributor

graydon commented Dec 7, 2012

@brson how about naming the module serial with Encoder, Decoder, etc. as its members?

I'm just concerned with the -izable and -ization suffixes. Very chatty.

@brson
Copy link
Contributor

brson commented Dec 8, 2012

I like serial better than code.

@erickt
Copy link
Contributor Author

erickt commented Dec 8, 2012

@brson: do you also prefer serial::Serializer over serial::Encoder as well?

@alexrp
Copy link

alexrp commented Dec 8, 2012

FWIW, when I hear serial I can't help but wonder "does this work with serial ports or something?". It seems a rather unintuitive name to me. coding also isn't very clear. encoding is somewhat clear but can be confused with character encoding. serialization is clear.

It seems that the intention of this pull request is to rename the module for the sake of less typing (which is understandable) but making it less clear in the process what the module actually does. Is that really worth it?

Not intending to walk all over your work @erickt, I'm just wondering if it's really a good direction to go. :)

@kud1ing
Copy link

kud1ing commented Dec 9, 2012

FWIW Go uses encoding: http://golang.org/pkg/encoding/

@erickt
Copy link
Contributor Author

erickt commented Dec 10, 2012

@alexrp: Not a problem. I'm not crazy about std::code either. I haven't really thought about serial ports in a long time, so that's not my first thought :) I'll bring this up in #rust today so we can hash this out with the community.

@brson
Copy link
Contributor

brson commented Dec 10, 2012

@erickt I do prefer Serializer over Encoder, but not a strong preference.

@erickt
Copy link
Contributor Author

erickt commented Dec 11, 2012

Updated to the final std::serialize::Encoder form. This will require two snapshots. First is to build c8e6b8f, make a snapshot, then build 8a2e7d7, then another snapshot, then 29fc340.

@erickt
Copy link
Contributor Author

erickt commented Dec 20, 2012

Merged in (finally!), closing.

@erickt erickt closed this Dec 20, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants