Handle ordered lists as well #41049
Closed
Handle ordered lists as well #41049
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@bors r+ |
|
📌 Commit b02cb19 has been approved by |
13 tasks
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 4, 2017
…, r=frewsxcv Handle ordered lists as well Part of rust-lang#40912. r? @rust-lang/docs
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 4, 2017
…, r=frewsxcv Handle ordered lists as well Part of rust-lang#40912. r? @rust-lang/docs
steveklabnik
reviewed
Apr 5, 2017
src/librustdoc/html/markdown.rs
Outdated
| } | ||
| buffer.push_str(&format!("<li>{}</li>", content)); | ||
| } | ||
|
|
||
| fn list(parser: &mut ParserWrapper, buffer: &mut String, toc_builder: &mut Option<TocBuilder>, | ||
| shorter: MarkdownOutputStyle) { | ||
| shorter: MarkdownOutputStyle, is_sorted_list: bool) { |
There was a problem hiding this comment.
shouldn't this be "ordered" and not "sorted"
There was a problem hiding this comment.
I don't think this is a huge deal
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 5, 2017
…, r=frewsxcv Handle ordered lists as well Part of rust-lang#40912. r? @rust-lang/docs
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Apr 5, 2017
…, r=frewsxcv Handle ordered lists as well Part of rust-lang#40912. r? @rust-lang/docs
bors
added a commit
that referenced
this pull request
Apr 5, 2017
GuillaumeGomez
force-pushed
the
rustdoc-ordered-list
branch
from
b02cb19
to
5652561
Compare
|
@bors: r=frewsxcv |
|
📌 Commit 5652561 has been approved by |
|
Note that if the rollup lands, your commit is not going to be included |
|
Yes, i should have just not commented.
…On Wed, Apr 5, 2017 at 1:11 PM, Corey Farwell ***@***.***> wrote:
Note that if the rollup lands, your commit is not going to be included
—
You are receiving this because you are on a team that was mentioned.
Reply to this email directly, view it on GitHub
<#41049 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AABsimAXCvyb2rvOi6E9MxRGht9NEuOZks5rs8svgaJpZM4MyK0B>
.
|
|
Ah damn. :'( I'll write a "fix" afterwards then. |
|
☔ The latest upstream changes (presumably #41086) made this pull request unmergeable. Please resolve the merge conflicts. |
|
This was actually merged, the amendment after didn't make it, but that's fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #40912.
r? @rust-lang/docs