Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Let .rev()'s find use the underlying rfind and vice versa #41028

Merged
merged 2 commits into from
Apr 6, 2017
Merged

Let .rev()'s find use the underlying rfind and vice versa #41028

merged 2 commits into from
Apr 6, 2017

Conversation

bluss
Copy link
Member

@bluss bluss commented Apr 3, 2017

  • Connect the plumbing in an obvious way from Rev's find → underlying rfind and vice versa
  • A style change in the provided implementation for Iterator::rfind, using simple next_back when it is enough

@bluss
iter: Use underlying find/rfind for the same methods in Rev
29a6a9e
@bluss
iter: Simplification in rfind's provided implementation
74f8ea2 
- Prefer simpler constructs instead of going through &mut I's Iterator
  implementation.
@rust-highfive
Copy link
Collaborator

r? @brson

(rust_highfive has picked a reviewer for you, use r? to override)

@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Apr 3, 2017

📌 Commit 74f8ea2 has been approved by alexcrichton

@frewsxcv frewsxcv mentioned this pull request Apr 3, 2017
Closed
@arielb1 arielb1 mentioned this pull request Apr 5, 2017
Closed
arielb1 pushed a commit to arielb1/rust that referenced this pull request Apr 5, 2017
Rollup merge of rust-lang#41028 - bluss:rev-rfind, r=alexcrichton
5e410ba 
Let .rev()'s find use the underlying rfind and vice versa

- Connect the plumbing in an obvious way from Rev's find → underlying rfind and vice versa
- A style change in the provided implementation for Iterator::rfind, using simple next_back when it is enough
@arielb1 arielb1 mentioned this pull request Apr 5, 2017
Merged
bors added a commit that referenced this pull request Apr 6, 2017
@bors
Auto merge of #41098 - arielb1:rollup, r=arielb1
6cd15a0 
Rollup of 12 pull requests

- Successful merges: #40479, #40561, #40709, #40815, #40909, #40927, #40943, #41015, #41028, #41052, #41054, #41065
- Failed merges:
@bors bors merged commit 74f8ea2 into rust-lang:master Apr 6, 2017
@bluss bluss deleted the rev-rfind branch April 6, 2017 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@brson brson

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@bluss @rust-highfive @alexcrichton @bors @brson