Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correcting mistakes in the README.md #40797

Merged
merged 2 commits into from
Apr 7, 2017
Merged

Correcting mistakes in the README.md #40797

merged 2 commits into from
Apr 7, 2017

Conversation

GAJaloyan
Copy link
Contributor

Correcting the two mistakes in the README.md (issue #40793)

@GAJaloyan
issue #40793
03949f5 
Correcting the two mistakes in the README.md
@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @arielb1 (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@GAJaloyan
correcting another mistake in an example
c80868e 
copy_pointer -> copy_borrowed_ptr
@GAJaloyan
Copy link
Contributor Author

I corrected another mistake in an example: the name of the function defined does not match the called function in the main function.

@arielb1
Copy link
Contributor

arielb1 commented Apr 6, 2017

We are going to tear this down anyway, but
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 6, 2017

📌 Commit c80868e has been approved by arielb1

frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 7, 2017
@frewsxcv
Rollup merge of rust-lang#40797 - GAJaloyan:patch-1, r=arielb1
c749a77 
Correcting mistakes in the README.md

Correcting the two mistakes in the README.md (issue rust-lang#40793)
@frewsxcv frewsxcv mentioned this pull request Apr 7, 2017
Closed
@frewsxcv frewsxcv mentioned this pull request Apr 7, 2017
Closed
frewsxcv added a commit to frewsxcv/rust that referenced this pull request Apr 7, 2017
@frewsxcv
Rollup merge of rust-lang#40797 - GAJaloyan:patch-1, r=arielb1
d860b1c 
Correcting mistakes in the README.md

Correcting the two mistakes in the README.md (issue rust-lang#40793)
@frewsxcv frewsxcv mentioned this pull request Apr 7, 2017
Merged
bors added a commit that referenced this pull request Apr 7, 2017
@bors
Auto merge of #41138 - frewsxcv:rollup, r=frewsxcv
53f4bc3 
Rollup of 9 pull requests

- Successful merges: #40797, #41047, #41056, #41061, #41075, #41080, #41120, #41130, #41131
- Failed merges:
@bors bors merged commit c80868e into rust-lang:master Apr 7, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@arielb1 arielb1

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@GAJaloyan @rust-highfive @arielb1 @bors