Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #40633

Closed
wants to merge 30 commits into from
Closed

Rollup of 8 pull requests #40633

wants to merge 30 commits into from

Commits on Mar 15, 2017

  1. Rename TryFrom's associated type and implement str::parse using TryFrom.

    Per discussion on the tracking issue, naming `TryFrom`'s associated type
    `Error` is generally more consistent with similar traits in the Rust
    ecosystem, and what people seem to assume it should be called. It
    also helps disambiguate from `Result::Err`, the most common "Err".
    
    See
    rust-lang#33417 (comment).
    
    TryFrom<&str> and FromStr are equivalent, so have the latter provide the
    former to ensure that. Using TryFrom in the implementation of
    `str::parse` means types that implement either trait can use it.
    When we're ready to stabilize `TryFrom`, we should update `FromStr` to
    suggest implementing `TryFrom<&str>` instead for new code.
    
    See
    rust-lang#33417 (comment)
    and
    rust-lang#33417 (comment).
    
    Refs rust-lang#33417.
    jimmycuadra authored and alexcrichton committed Mar 15, 2017
    Configuration menu
    Copy the full SHA
    2561dcd View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2017

  1. Configuration menu
    Copy the full SHA
    50cede0 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    963d4df View commit details
    Browse the repository at this point in the history
  3. Fix typo in mutex.rs docs

    This seems to match other uses of "be accessed" in the document.
    ScottAbbey authored Mar 17, 2017
    Configuration menu
    Copy the full SHA
    ec8ecf4 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    33a5665 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    65b7c4e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    d38ea8b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    9511fe6 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    10510ae View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    37b38a2 View commit details
    Browse the repository at this point in the history
  10. Configuration menu
    Copy the full SHA
    48890d4 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    a8f4a1b View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    1241a88 View commit details
    Browse the repository at this point in the history

Commits on Mar 18, 2017

  1. Configuration menu
    Copy the full SHA
    2976ddb View commit details
    Browse the repository at this point in the history
  2. Fix race condition in fs::create_dir_all

    It is more robust to not fail if any directory in a path was created
    concurrently. This change lifts rustc internal `create_dir_racy` that
    was created to handle such conditions to be new `create_dir_all`
    implementation.
    droundy authored and dpc committed Mar 18, 2017
    Configuration menu
    Copy the full SHA
    db00ba9 View commit details
    Browse the repository at this point in the history
  3. Fix new version of create_dir_all

    It will now correctly fail on existing non-directories.
    dpc committed Mar 18, 2017
    Configuration menu
    Copy the full SHA
    0ec28b7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f2adee7 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    a51c6aa View commit details
    Browse the repository at this point in the history
  6. Fix problems found on Windows in dir_create_all

    Ignore the type of error altogether. The rationale is: it doesn't matter
    what was the problem if the directory is there. In the previous versions
    if the directory was there already we wouldn't even attempt to create
    it, so we wouldn't know about the problem neither.
    
    Make test path length smaller in `concurrent_recursive_mkdir` test.
    dpc committed Mar 18, 2017
    Configuration menu
    Copy the full SHA
    c3e2eaf View commit details
    Browse the repository at this point in the history
  7. Reorder match checks in create_dir_all

    Avoid doing `is_dir` in the fast path.
    dpc committed Mar 18, 2017
    Configuration menu
    Copy the full SHA
    bcae6a3 View commit details
    Browse the repository at this point in the history
  8. Fix create_dir_all("")

    Add a test for `""` and `"."`.
    dpc committed Mar 18, 2017
    Configuration menu
    Copy the full SHA
    b5d590b View commit details
    Browse the repository at this point in the history
  9. Update the cargo submodule again

    Unfortunately it was reverted back to a broken state in
    e06c515 by accident, so let's bring it forward
    again!
    alexcrichton committed Mar 18, 2017
    Configuration menu
    Copy the full SHA
    9fb737b View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#39799 - dpc:create_dir_all, r=alexcrichton

    Fix race condition in fs::create_dir_all
    
    The code would crash if the directory was created after create_dir_all
    checked whether the directory already existed.  This was contrary to
    the documentation which claimed to create the directory if it doesn't
    exist, implying (but not stating) that there would not be a failure
    due to the directory existing.
    frewsxcv authored Mar 18, 2017
    Configuration menu
    Copy the full SHA
    95896bd View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#40281 - jimmycuadra:try-from-from-str, r=at…

    …uron
    
    Rename TryFrom's associated type and implement str::parse using TryFrom.
    
    Per discussion on the tracking issue, naming `TryFrom`'s associated type `Error` is generally more consistent with similar traits in the Rust ecosystem, and what people seem to assume it should be called. It also helps disambiguate from `Result::Err`, the most common "Err".
    
    See rust-lang#33417 (comment).
    
    `TryFrom<&str>` and `FromStr` are equivalent, so have the latter provide the former to ensure that. Using `TryFrom` in the implementation of `str::parse` means types that implement either trait can use it. When we're ready to stabilize `TryFrom`, we should update `FromStr` to
    suggest implementing `TryFrom<&str>` instead for new code.
    
    See rust-lang#33417 (comment)
    and rust-lang#33417 (comment).
    
    Refs rust-lang#33417.
    frewsxcv authored Mar 18, 2017
    Configuration menu
    Copy the full SHA
    e9e3d5f View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#40538 - aturon:stab-1.17, r=alexcrichton

    Library stabilizations for 1.17
    
    Details of the stabilizations are available in the commits. Includes only library stabilizations; there are a couple of compiler stabilizations that should also be done for 1.17.
    
    Will need a beta backport, which I will create after approval.
    
    r? @alexcrichton
    frewsxcv authored Mar 18, 2017
    Configuration menu
    Copy the full SHA
    08c9ad1 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#40590 - z1mvader:master, r=steveklabnik

    documented order of conversion between u32 an ipv4addr
    
    This fixes rust-lang#40118
    frewsxcv authored Mar 18, 2017
    Configuration menu
    Copy the full SHA
    a26c37b View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#40603 - QuietMisdreavus:slice-ptr-docs, r=G…

    …uillaumeGomez
    
    minor wording tweak to slice::{as_ptr, as_mut_ptr}
    
    Per rust-lang#37334, the slice-as-pointer methods mentioned that "modifying the slice may cause its buffer to be reallocated", when in fact modifying the *slice* itself would cause no such change. (It is a borrow, after all!) This is a tweak to the wording of that line to stress it's the *collection* that could cause the buffer to be reallocated.
    
    r? @steveklabnik
    frewsxcv authored Mar 18, 2017
    Configuration menu
    Copy the full SHA
    fc9f66f View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#40611 - ScottAbbey:patch-1, r=GuillaumeGomez

    Fix typo in mutex.rs docs
    
    This seems to match other uses of "be accessed" in the document.
    frewsxcv authored Mar 18, 2017
    Configuration menu
    Copy the full SHA
    eed4112 View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#40621 - jswalden:dependant-spelling-fix, r=…

    …sfackler
    
    Fix a spelling error in HashMap documentation, and slightly reword surrounding text for precision
    
    Noticed while reading docs just now.
    
    It's possible that the prior wording *meant* to state that the seed's randomness depends on the exact instant that the system RNG was created, I guess.  But unless there's an API guarantee that this is the case, the wording seems over-precise.  Is there a formal API guarantee that would forbid, say, the system RNG from generating all output using the Intel RDRAND instruction?  I don't think the quality of output in that case would depend on when the RNG was created.  Yet it seems to me like it could well be a valid source of randomness when computing the initial seed.
    
    For that reason, tying the randomness of the seed, to the quality of the RNG's output *at the precise instant the seed is computed*, seems less confining.  That instantaneous quality level could be determined by the quality at the instant the RNG was created -- but instantaneous quality need not be low for that precise reason.
    frewsxcv authored Mar 18, 2017
    Configuration menu
    Copy the full SHA
    bfc08bd View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#40625 - alexcrichton:update-cargo-again, r=…

    …alexcrichton
    
    Update the cargo submodule again
    
    Unfortunately it was reverted back to a broken state in
    e06c515 by accident, so let's bring it forward
    again!
    
    Closes rust-lang/cargo#3844
    frewsxcv authored Mar 18, 2017
    Configuration menu
    Copy the full SHA
    4419349 View commit details
    Browse the repository at this point in the history