-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 8 pull requests #40633
Rollup of 8 pull requests #40633
Commits on Mar 15, 2017
-
Rename TryFrom's associated type and implement str::parse using TryFrom.
Per discussion on the tracking issue, naming `TryFrom`'s associated type `Error` is generally more consistent with similar traits in the Rust ecosystem, and what people seem to assume it should be called. It also helps disambiguate from `Result::Err`, the most common "Err". See rust-lang#33417 (comment). TryFrom<&str> and FromStr are equivalent, so have the latter provide the former to ensure that. Using TryFrom in the implementation of `str::parse` means types that implement either trait can use it. When we're ready to stabilize `TryFrom`, we should update `FromStr` to suggest implementing `TryFrom<&str>` instead for new code. See rust-lang#33417 (comment) and rust-lang#33417 (comment). Refs rust-lang#33417.
Configuration menu - View commit details
-
Copy full SHA for 2561dcd - Browse repository at this point
Copy the full SHA 2561dcdView commit details
Commits on Mar 17, 2017
-
documented order of conversion between u32 an ipv4addr
z1mvader committedMar 17, 2017 Configuration menu - View commit details
-
Copy full SHA for 50cede0 - Browse repository at this point
Copy the full SHA 50cede0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 963d4df - Browse repository at this point
Copy the full SHA 963d4dfView commit details -
This seems to match other uses of "be accessed" in the document.
Configuration menu - View commit details
-
Copy full SHA for ec8ecf4 - Browse repository at this point
Copy the full SHA ec8ecf4View commit details -
Configuration menu - View commit details
-
Copy full SHA for 33a5665 - Browse repository at this point
Copy the full SHA 33a5665View commit details -
Configuration menu - View commit details
-
Copy full SHA for 65b7c4e - Browse repository at this point
Copy the full SHA 65b7c4eView commit details -
Configuration menu - View commit details
-
Copy full SHA for d38ea8b - Browse repository at this point
Copy the full SHA d38ea8bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9511fe6 - Browse repository at this point
Copy the full SHA 9511fe6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 10510ae - Browse repository at this point
Copy the full SHA 10510aeView commit details -
Configuration menu - View commit details
-
Copy full SHA for 37b38a2 - Browse repository at this point
Copy the full SHA 37b38a2View commit details -
Configuration menu - View commit details
-
Copy full SHA for 48890d4 - Browse repository at this point
Copy the full SHA 48890d4View commit details -
Configuration menu - View commit details
-
Copy full SHA for a8f4a1b - Browse repository at this point
Copy the full SHA a8f4a1bView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1241a88 - Browse repository at this point
Copy the full SHA 1241a88View commit details
Commits on Mar 18, 2017
-
Fix a spelling error in HashMap documentation, and slightly reword it…
… to be more precise.
Configuration menu - View commit details
-
Copy full SHA for 2976ddb - Browse repository at this point
Copy the full SHA 2976ddbView commit details -
Fix race condition in fs::create_dir_all
It is more robust to not fail if any directory in a path was created concurrently. This change lifts rustc internal `create_dir_racy` that was created to handle such conditions to be new `create_dir_all` implementation.
Configuration menu - View commit details
-
Copy full SHA for db00ba9 - Browse repository at this point
Copy the full SHA db00ba9View commit details -
Fix new version of
create_dir_all
It will now correctly fail on existing non-directories.
Configuration menu - View commit details
-
Copy full SHA for 0ec28b7 - Browse repository at this point
Copy the full SHA 0ec28b7View commit details -
Configuration menu - View commit details
-
Copy full SHA for f2adee7 - Browse repository at this point
Copy the full SHA f2adee7View commit details -
Configuration menu - View commit details
-
Copy full SHA for a51c6aa - Browse repository at this point
Copy the full SHA a51c6aaView commit details -
Fix problems found on Windows in
dir_create_all
Ignore the type of error altogether. The rationale is: it doesn't matter what was the problem if the directory is there. In the previous versions if the directory was there already we wouldn't even attempt to create it, so we wouldn't know about the problem neither. Make test path length smaller in `concurrent_recursive_mkdir` test.
Configuration menu - View commit details
-
Copy full SHA for c3e2eaf - Browse repository at this point
Copy the full SHA c3e2eafView commit details -
Reorder match checks in
create_dir_all
Avoid doing `is_dir` in the fast path.
Configuration menu - View commit details
-
Copy full SHA for bcae6a3 - Browse repository at this point
Copy the full SHA bcae6a3View commit details -
Configuration menu - View commit details
-
Copy full SHA for b5d590b - Browse repository at this point
Copy the full SHA b5d590bView commit details -
Update the cargo submodule again
Unfortunately it was reverted back to a broken state in e06c515 by accident, so let's bring it forward again!
Configuration menu - View commit details
-
Copy full SHA for 9fb737b - Browse repository at this point
Copy the full SHA 9fb737bView commit details -
Rollup merge of rust-lang#39799 - dpc:create_dir_all, r=alexcrichton
Fix race condition in fs::create_dir_all The code would crash if the directory was created after create_dir_all checked whether the directory already existed. This was contrary to the documentation which claimed to create the directory if it doesn't exist, implying (but not stating) that there would not be a failure due to the directory existing.
Configuration menu - View commit details
-
Copy full SHA for 95896bd - Browse repository at this point
Copy the full SHA 95896bdView commit details -
Rollup merge of rust-lang#40281 - jimmycuadra:try-from-from-str, r=at…
…uron Rename TryFrom's associated type and implement str::parse using TryFrom. Per discussion on the tracking issue, naming `TryFrom`'s associated type `Error` is generally more consistent with similar traits in the Rust ecosystem, and what people seem to assume it should be called. It also helps disambiguate from `Result::Err`, the most common "Err". See rust-lang#33417 (comment). `TryFrom<&str>` and `FromStr` are equivalent, so have the latter provide the former to ensure that. Using `TryFrom` in the implementation of `str::parse` means types that implement either trait can use it. When we're ready to stabilize `TryFrom`, we should update `FromStr` to suggest implementing `TryFrom<&str>` instead for new code. See rust-lang#33417 (comment) and rust-lang#33417 (comment). Refs rust-lang#33417.
Configuration menu - View commit details
-
Copy full SHA for e9e3d5f - Browse repository at this point
Copy the full SHA e9e3d5fView commit details -
Rollup merge of rust-lang#40538 - aturon:stab-1.17, r=alexcrichton
Library stabilizations for 1.17 Details of the stabilizations are available in the commits. Includes only library stabilizations; there are a couple of compiler stabilizations that should also be done for 1.17. Will need a beta backport, which I will create after approval. r? @alexcrichton
Configuration menu - View commit details
-
Copy full SHA for 08c9ad1 - Browse repository at this point
Copy the full SHA 08c9ad1View commit details -
Rollup merge of rust-lang#40590 - z1mvader:master, r=steveklabnik
documented order of conversion between u32 an ipv4addr This fixes rust-lang#40118
Configuration menu - View commit details
-
Copy full SHA for a26c37b - Browse repository at this point
Copy the full SHA a26c37bView commit details -
Rollup merge of rust-lang#40603 - QuietMisdreavus:slice-ptr-docs, r=G…
…uillaumeGomez minor wording tweak to slice::{as_ptr, as_mut_ptr} Per rust-lang#37334, the slice-as-pointer methods mentioned that "modifying the slice may cause its buffer to be reallocated", when in fact modifying the *slice* itself would cause no such change. (It is a borrow, after all!) This is a tweak to the wording of that line to stress it's the *collection* that could cause the buffer to be reallocated. r? @steveklabnik
Configuration menu - View commit details
-
Copy full SHA for fc9f66f - Browse repository at this point
Copy the full SHA fc9f66fView commit details -
Rollup merge of rust-lang#40611 - ScottAbbey:patch-1, r=GuillaumeGomez
Fix typo in mutex.rs docs This seems to match other uses of "be accessed" in the document.
Configuration menu - View commit details
-
Copy full SHA for eed4112 - Browse repository at this point
Copy the full SHA eed4112View commit details -
Rollup merge of rust-lang#40621 - jswalden:dependant-spelling-fix, r=…
…sfackler Fix a spelling error in HashMap documentation, and slightly reword surrounding text for precision Noticed while reading docs just now. It's possible that the prior wording *meant* to state that the seed's randomness depends on the exact instant that the system RNG was created, I guess. But unless there's an API guarantee that this is the case, the wording seems over-precise. Is there a formal API guarantee that would forbid, say, the system RNG from generating all output using the Intel RDRAND instruction? I don't think the quality of output in that case would depend on when the RNG was created. Yet it seems to me like it could well be a valid source of randomness when computing the initial seed. For that reason, tying the randomness of the seed, to the quality of the RNG's output *at the precise instant the seed is computed*, seems less confining. That instantaneous quality level could be determined by the quality at the instant the RNG was created -- but instantaneous quality need not be low for that precise reason.
Configuration menu - View commit details
-
Copy full SHA for bfc08bd - Browse repository at this point
Copy the full SHA bfc08bdView commit details -
Rollup merge of rust-lang#40625 - alexcrichton:update-cargo-again, r=…
…alexcrichton Update the cargo submodule again Unfortunately it was reverted back to a broken state in e06c515 by accident, so let's bring it forward again! Closes rust-lang/cargo#3844
Configuration menu - View commit details
-
Copy full SHA for 4419349 - Browse repository at this point
Copy the full SHA 4419349View commit details