rustbuild: Make save-analysis an option #40383
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @brson (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
src/bootstrap/dist.rs
Outdated
| @@ -313,16 +313,8 @@ pub fn rust_src_location(build: &Build) -> PathBuf { | |||
| pub fn analysis(build: &Build, compiler: &Compiler, target: &str) { | |||
| println!("Dist analysis"); | |||
|
|
|||
| if build.config.channel != "nightly" { | |||
There was a problem hiding this comment.
I think this step should remain in the form of if !build.config.rust_save_analysis, right?
ishitatsuyuki
force-pushed
the
easy-dist-analysis
branch
from
96cc5ff
to
d4040c3
Compare
|
@bors: r+ |
|
📌 Commit d4040c3 has been approved by |
rustbuild: Make save-analysis an option This makes save-analysis an option independent from the release channel. The CI build scripts have been modified to enable the flag. *Merge with caution.* I haven't tested this, and this can cause nightly breakage.
|
☀️ Test successful - status-appveyor, status-travis |
This makes save-analysis an option independent from the release channel.
The CI build scripts have been modified to enable the flag.
Merge with caution. I haven't tested this, and this can cause nightly breakage.