Beta backport of #40254 #40256
Beta backport of #40254 #40256
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
|
|
@bors: r+ p=1 (beta backport) |
|
📌 Commit e8d90fb has been approved by |
|
⌛ Testing commit e8d90fb with merge 5047e41... |
|
💔 Test failed - status-appveyor |
|
@bors: retry
* failed to upload to S3
…On Mon, Mar 6, 2017 at 12:58 PM, bors ***@***.***> wrote:
💔 Test failed - status-appveyor
<https://ci.appveyor.com/project/rust-lang/rust/build/1.0.2245>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#40256 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95BxfRgr6coc1ylVloxFFoyxfyjQBks5rjFdDgaJpZM4MTDFt>
.
|
|
⌛ Testing commit e8d90fb with merge edf1ef4... |
|
💔 Test failed - status-travis |
|
… On Mon, Mar 6, 2017 at 2:42 PM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/208329862>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#40256 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95O6e1NgBkf9dJOLVVxtqdWI9RsZvks5rjG-hgaJpZM4MTDFt>
.
|
|
⌛ Testing commit e8d90fb with merge e204742... |
|
@alexcrichton Shouldn't this PR include a version bump since every beta publishes? Landing this will publish a beta with the same number as previously. |
|
💥 Test timed out |
|
@bors: retry
|
|
⌛ Testing commit e8d90fb with merge 6e3a32a... |
So how is it? Seems weird and error prone to make contributors to do this if that’s true. |
|
Oh sorry I meant to respond to that. No a version bump isn't necessary. The rust-central-station supports only publishes betas if the version changes, unlike nightlies where a version is published if the revision changes. |
|
💔 Test failed - status-travis |
|
… On Tue, Mar 7, 2017 at 10:12 AM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/208625694>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#40256 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95C2LR1eIDGVCYp0ThpDNoa_Vy25Aks5rjYHbgaJpZM4MTDFt>
.
|
|
⌛ Testing commit e8d90fb with merge 99b423e... |
|
💔 Test failed - status-travis |
|
… On Tue, Mar 7, 2017 at 1:56 PM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/208686334>
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#40256 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95BnQbu2_Kw6Qv8NgLegDeUwfQ6IUks5rjbZXgaJpZM4MTDFt>
.
|
|
⌛ Testing commit e8d90fb with merge 92e7b9b... |
|
☀️ Test successful - status-appveyor, status-travis |
No description provided.