[MIR] Make InlineAsm a Statement #39854
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously InlineAsm was an Rvalue, but its semantics doesn’t really match the semantics of an Rvalue – rather it behaves more like a Statement.
gereeter
reviewed
Feb 16, 2017
| } | ||
| // FIXME: rvalue with undeterminable type - e.g. AggregateKind::Array branch that | ||
| // returns `None`. |
There was a problem hiding this comment.
If I understand correctly, this case (the only remaining case that returns None now that InlineAsm is gone) is for empty arrays. I think that returning [!; 0] would be the correct behavior, removing the need to return an Option.
There was a problem hiding this comment.
At least currently [T; 0] is not a subtype of [!; 0] so no, that would not work.
There was a problem hiding this comment.
I think the problem is that Array ought to carry the type of its elements.
|
@bors r+ |
|
📌 Commit 4a3c66a has been approved by |
|
Thanks @nagisa ! |
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Feb 16, 2017
[MIR] Make InlineAsm a Statement Previously InlineAsm was an Rvalue, but its semantics doesn’t really match the semantics of an Rvalue – rather it behaves more like a Statement. r? @nikomatsakis you wanted this to happen
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 17, 2017
[MIR] Make InlineAsm a Statement Previously InlineAsm was an Rvalue, but its semantics doesn’t really match the semantics of an Rvalue – rather it behaves more like a Statement. r? @nikomatsakis you wanted this to happen
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 17, 2017
[MIR] Make InlineAsm a Statement Previously InlineAsm was an Rvalue, but its semantics doesn’t really match the semantics of an Rvalue – rather it behaves more like a Statement. r? @nikomatsakis you wanted this to happen
|
@bors: retry |
bors
added a commit
that referenced
this pull request
Feb 18, 2017
[MIR] Make InlineAsm a Statement Previously InlineAsm was an Rvalue, but its semantics doesn't really match the semantics of an Rvalue - rather it behaves more like a Statement. r? @nikomatsakis you wanted this to happen
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously InlineAsm was an Rvalue, but its semantics doesn't really match the semantics of an
Rvalue - rather it behaves more like a Statement.
r? @nikomatsakis you wanted this to happen