Actually fix manifest generation #39676
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous fix contained an error where `toml::encode` returned a runtime error, so this version just constructs a literal `toml::Value`.
|
r? @brson |
|
(rust_highfive has picked a reviewer for you, use r? to override) |
|
@bors r+ |
|
📌 Commit de59d5d has been approved by |
alexcrichton
added
the
beta-nominated
|
Nominating for a beta backport |
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 11, 2017
Actually fix manifest generation The previous fix contained an error where `toml::encode` returned a runtime error, so this version just constructs a literal `toml::Value`.
frewsxcv
added a commit
to frewsxcv/rust
that referenced
this pull request
Feb 11, 2017
Actually fix manifest generation The previous fix contained an error where `toml::encode` returned a runtime error, so this version just constructs a literal `toml::Value`.
bors
added a commit
that referenced
this pull request
Feb 11, 2017
alexcrichton
added
the
beta-accepted
brson
removed
the
beta-nominated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The previous fix contained an error where
toml::encodereturned a runtimeerror, so this version just constructs a literal
toml::Value.