save-analysis: handle paths in type/trait context more correctly #38952
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TBH, this is still not perfect, witness the FIXME, but it is an improvement. In particular it means we get information about trait references in impls.
|
r? @eddyb (rust_highfive has picked a reviewer for you, use r? to override) |
eddyb
approved these changes
Jan 10, 2017
|
@bors r+ |
|
📌 Commit 745a5e8 has been approved by |
|
⌛ Testing commit 745a5e8 with merge f16510e... |
|
💔 Test failed - status-travis |
|
… On Tue, Jan 10, 2017 at 10:07 AM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/190667954>
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#38952 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95I9TjQsQ_WqyzYfflTgHDlMYZn-1ks5rQ8jJgaJpZM4Le_GC>
.
|
bors
added a commit
that referenced
this pull request
Jan 11, 2017
save-analysis: handle paths in type/trait context more correctly TBH, this is still not perfect, witness the FIXME, but it is an improvement. In particular it means we get information about trait references in impls.
|
💔 Test failed - status-travis |
|
@bors: retry
* spurious docker failure
…On Wed, Jan 11, 2017 at 5:42 AM, bors ***@***.***> wrote:
💔 Test failed - status-travis
<https://travis-ci.org/rust-lang/rust/builds/190954170>
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#38952 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAD95MdZGIpiaaEY0Kg9-40tEjJTQL7Eks5rRNw7gaJpZM4Le_GC>
.
|
bors
added a commit
that referenced
this pull request
Jan 14, 2017
save-analysis: handle paths in type/trait context more correctly TBH, this is still not perfect, witness the FIXME, but it is an improvement. In particular it means we get information about trait references in impls.
|
☀️ Test successful - status-appveyor, status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TBH, this is still not perfect, witness the FIXME, but it is an improvement. In particular it means we get information about trait references in impls.