Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

clear discriminant drop flag at the bottom of a drop ladder #38600

Merged
merged 1 commit into from
Dec 27, 2016
Merged

clear discriminant drop flag at the bottom of a drop ladder #38600

merged 1 commit into from
Dec 27, 2016

Conversation

arielb1
Copy link
Contributor

@arielb1 arielb1 commented Dec 25, 2016 •
edited
Loading

Fixes #38437.

Beta-nominating because serious I-wrong.

r? @eddyb

@rust-highfive
Copy link
Collaborator

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@arielb1 arielb1 changed the title clear discriminant drop flag at the bottom of a ladder clear discriminant drop flag at the bottom of a drop ladder Dec 25, 2016
@arielb1 arielb1 added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Dec 25, 2016
@eddyb
Copy link
Member

eddyb commented Dec 25, 2016

@bors r+

@bors
Copy link
Contributor

bors commented Dec 25, 2016

📌 Commit 521b2ea has been approved by eddyb

@alexcrichton
Copy link
Member

@bors: p=1

(beta nominated)

@bors
Copy link
Contributor

bors commented Dec 27, 2016

⌛ Testing commit 521b2ea with merge 17e4079...

@bors
Copy link
Contributor

bors commented Dec 27, 2016

💔 Test failed - status-appveyor

@alexcrichton
Copy link
Member

alexcrichton commented Dec 27, 2016 via email

@bors
Copy link
Contributor

bors commented Dec 27, 2016

⌛ Testing commit 521b2ea with merge 82801b5...

bors added a commit that referenced this pull request Dec 27, 2016
@bors
Auto merge of #38600 - arielb1:dead-drop, r=eddyb
82801b5 
clear discriminant drop flag at the bottom of a drop ladder

Fixes #38437.

Beta-nominating because serious I-wrong.

r? @eddyb
@bors
Copy link
Contributor

bors commented Dec 27, 2016

☀️ Test successful - status-appveyor, status-travis
Approved by: eddyb
Pushing 82801b5 to master...

@bors bors merged commit 521b2ea into rust-lang:master Dec 27, 2016
@alexcrichton alexcrichton mentioned this pull request Dec 27, 2016
Closed
@nikomatsakis
Copy link
Contributor

Marking as beta-accepted. Patch narrow in scope, serious regression. cc @rust-lang/compiler

@nikomatsakis nikomatsakis added the beta-accepted Accepted for backporting to the compiler in the beta channel. label Dec 30, 2016
This was referenced Dec 30, 2016
Closed
Merged
@brson brson removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Dec 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@eddyb eddyb

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@arielb1 @rust-highfive @eddyb @bors @alexcrichton @nikomatsakis @brson