ICH: Fix and test foreign mod hashing. #38479
Conversation
| match i.node { | ||
| ForeignItemFn(ref fn_decl, _) => { | ||
| SawForeignItem(SawForeignItemComponent::Fn { | ||
| variadic: fn_decl.variadic |
There was a problem hiding this comment.
Shouldn't this be part of FnDecl?
There was a problem hiding this comment.
visit_fn() is not called for foreign items, and it's not clear that it should be (since foreign items have no body like the other cases). As far as I could tell, this is the only way to get at a foreign item's FnDecl without changing the visitor implementation.
There was a problem hiding this comment.
Oh there is no visit_fn_decl? Maybe you should add that instead.
There was a problem hiding this comment.
I'm afraid, you're right :)
michaelwoerister
force-pushed
the
extern_mod_ich
branch
from
7c02e14
to
bd6dfa3
Compare
|
I've added a |
michaelwoerister
force-pushed
the
extern_mod_ich
branch
from
bd6dfa3
to
f0a630b
Compare
|
I removed hashes for individual foreign items, which caused no trouble for the |
|
@michaelwoerister looks good. 👍 |
|
@michaelwoerister though I feel like this caused some sort of ICE -- do you think you could use this branch to build syntex with RUSTFLAGS="-Z incremental" or something like that? |
Sure. |
|
So, I did a full bootstrap on this branch, with both stage1 and stage2 being built with |
|
@bors r+ |
|
📌 Commit f0a630b has been approved by |
ICH: Fix and test foreign mod hashing. r? @nikomatsakis
|
☀️ Test successful - status-appveyor, status-travis |
r? @nikomatsakis