Fix unaligned loads in librustc_metadata #38352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
bluss
commented
Dec 13, 2016
| fn bytes_to_words(b: &[u8]) -> &[u32] { | ||
| unsafe { slice::from_raw_parts(b.as_ptr() as *const u32, b.len() / 4) } | ||
| fn bytes_to_words(b: &[u8]) -> UnalignedIter<u32> { | ||
| UnalignedIter::from_slice(b) |
There was a problem hiding this comment.
hm.. no, sorry! It is from before that.
|
This was reported as a crash on sparc64. |
bluss
force-pushed
the
unaligned-metadata
branch
from
60fd4e4
to
e6dc830
Compare
bluss
commented
Dec 13, 2016
| @@ -95,8 +98,8 @@ impl<'tcx> LazySeq<Index> { | |||
| } | |||
| } | |||
|
|
|||
| fn bytes_to_words(b: &[u8]) -> &[u32] { | |||
| unsafe { slice::from_raw_parts(b.as_ptr() as *const u32, b.len() / 4) } | |||
There was a problem hiding this comment.
Maybe we should lint against this? Creating a slice or reference from a less aligned pointer?
Creating a `&[u32]` from a `&[u8]` was not valid; the data is not necessarily well aligned.
bluss
force-pushed
the
unaligned-metadata
branch
from
e6dc830
to
7bc1054
Compare
|
Hey presto, the diff is much shorter with a bit of help from @eddyb. |
|
@bors r+ |
|
📌 Commit 7bc1054 has been approved by |
bors
added a commit
that referenced
this pull request
Dec 16, 2016
Fix unaligned loads in librustc_metadata Creating a `&[u32]` from an `&[u8]` is not necessarily valid, and crashes on certain platforms if the data is not well aligned.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a
&[u32]from an&[u8]is not necessarily valid, and crasheson certain platforms if the data is not well aligned.