Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename 'librustc_unicode' crate to 'libstd_unicode'. #38049

Merged
merged 1 commit into from
Dec 12, 2016

Conversation

frewsxcv
Copy link
Member

Fixes #26554.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @aturon (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@frewsxcv frewsxcv mentioned this pull request Nov 28, 2016
@Kimundi Kimundi added the T-libs-api Relevant to the library API team, which will review and decide on the PR/issue. label Nov 28, 2016
Copy link
Member

@Kimundi Kimundi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes look fine so far - question is just if unicode is maybe a too general name for its std-specific purpose.

@alexcrichton
Copy link
Member

Discussed a bit during triage and conclusion was that a name like std_unicode is the way to go now, we're not quite ready to take the sweet unicode name yet.

@frewsxcv
Copy link
Member Author

Discussed a bit during triage and conclusion was that a name like std_unicode is the way to go now

Changes have been made in the latest force push.

@frewsxcv frewsxcv changed the title Rename 'librustc_unicode' crate to 'libunicode'. Rename 'librustc_unicode' crate to 'libstd_unicode'. Nov 29, 2016
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Nov 29, 2016

📌 Commit c904a36 has been approved by alexcrichton

@ollie27
Copy link
Member

ollie27 commented Nov 30, 2016

Presumably the Makefiles will need to be updated as well. This was attempted before: #36806.

@frewsxcv
Copy link
Member Author

Presumably the Makefiles will need to be updated as well.

Good catch. Fixed in the latest force push. r? @alexcrichton

@rust-highfive rust-highfive assigned alexcrichton and unassigned aturon Nov 30, 2016
@alexcrichton
Copy link
Member

@bors: r+

@bors
Copy link
Contributor

bors commented Nov 30, 2016

📌 Commit 274777a has been approved by alexcrichton

@frewsxcv
Copy link
Member Author

frewsxcv commented Dec 1, 2016

@bors r=-50

This is not super important. Doesn't need to be prioritized.

@bors
Copy link
Contributor

bors commented Dec 1, 2016

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Dec 1, 2016

📌 Commit 274777a has been approved by -50

@frewsxcv
Copy link
Member Author

frewsxcv commented Dec 1, 2016

@bors r=alexcrichton p=-50

@bors
Copy link
Contributor

bors commented Dec 1, 2016

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented Dec 1, 2016

📌 Commit 274777a has been approved by alexcrichton

@nagisa
Copy link
Member

nagisa commented Dec 2, 2016

AFAIR according to #24428, the rustc_unicode crate is supposed to be a facade for the compiler itself? In that case rustc_unicode makes very much sense to me.

@Kimundi
Copy link
Member

Kimundi commented Dec 3, 2016

std uses it as well though, and the compiler uses std, so the dependency chain works out as "compiler using a part of the std lib", which makes more sense than what the current name implies, which is "std uses part of the compiler lib".

@bors
Copy link
Contributor

bors commented Dec 12, 2016

⌛ Testing commit 274777a with merge b4b1e5e...

bors added a commit that referenced this pull request Dec 12, 2016
Rename 'librustc_unicode' crate to 'libstd_unicode'.

Fixes #26554.
@bors bors merged commit 274777a into rust-lang:master Dec 12, 2016
@bors bors mentioned this pull request Dec 12, 2016
2 tasks
@frewsxcv frewsxcv deleted the libunicode branch December 12, 2016 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-libs-api Relevant to the library API team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants