Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up ast::Attribute, ast::CrateConfig, and string interning #37824

Merged
merged 12 commits into from
Nov 21, 2016
Merged

Clean up ast::Attribute, ast::CrateConfig, and string interning #37824

merged 12 commits into from
Nov 21, 2016

Commits on Nov 20, 2016

  1. Refactor away ast::Attribute_.

    @jseyfried
    jseyfried committed Nov 20, 2016
    Configuration menu
    Copy the full SHA
    3ea2bc4 View commit details
    Browse the repository at this point in the history

  2. Avoid clearing the string interner.

    @jseyfried
    jseyfried committed Nov 20, 2016
    Configuration menu
    Copy the full SHA
    ff49942 View commit details
    Browse the repository at this point in the history

  3. Refactor MetaItemKind to use Names instead of InternedStrings.

    @jseyfried
    jseyfried committed Nov 20, 2016
    Configuration menu
    Copy the full SHA
    a262641 View commit details
    Browse the repository at this point in the history

  4. Refactor CrateConfig.

    @jseyfried
    jseyfried committed Nov 20, 2016
    Configuration menu
    Copy the full SHA
    4b9b0d3 View commit details
    Browse the repository at this point in the history

  5. Move MetaItemKind's Name to a field of MetaItem.

    @jseyfried
    jseyfried committed Nov 20, 2016
    Configuration menu
    Copy the full SHA
    e97686d View commit details
    Browse the repository at this point in the history

  6. Refactor P<ast::MetaItem> -> ast::MetaItem.

    @jseyfried
    jseyfried committed Nov 20, 2016
    Configuration menu
    Copy the full SHA
    f177a00 View commit details
    Browse the repository at this point in the history

  7. Move syntax::util::interner -> syntax::symbol, cleanup.

    @jseyfried
    jseyfried committed Nov 20, 2016
    Configuration menu
    Copy the full SHA
    d2f8fb0 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2016

  1. Use Symbol instead of InternedString in the AST, HIR, and various… 

    … other places.
    @jseyfried
    jseyfried committed Nov 21, 2016
    Configuration menu
    Copy the full SHA
    e85a0d7 View commit details
    Browse the repository at this point in the history

  2. Cleanup InternedString.

    @jseyfried
    jseyfried committed Nov 21, 2016
    Configuration menu
    Copy the full SHA
    36c8f6b View commit details
    Browse the repository at this point in the history

  3. Remove Rc from the interner.

    @jseyfried
    jseyfried committed Nov 21, 2016
    Configuration menu
    Copy the full SHA
    cc74068 View commit details
    Browse the repository at this point in the history

  4. Fix incremental compilation hashing.

    @jseyfried
    jseyfried committed Nov 21, 2016
    Configuration menu
    Copy the full SHA
    c9935e4 View commit details
    Browse the repository at this point in the history

  5. Fix fallout in rustdoc and tests.

    @jseyfried
    jseyfried committed Nov 21, 2016
    Configuration menu
    Copy the full SHA
    a8e86f0 View commit details
    Browse the repository at this point in the history