Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RFC] Add flag for Unicode based Frontend support #37703

Closed
wants to merge 1 commit into from

Conversation

estebank
Copy link
Contributor

Using PR #21406 as a base, I took a stab at #24387.

It currently looks like this:
screen shot 2016-11-10 at 20 21 24

As you can see, there's still some work left to do in order for the different combinations of underlines to look right, but the basic logic is already all there.

@rust-highfive
Copy link
Collaborator

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@frewsxcv
Copy link
Member

@eddyb
Copy link
Member

eddyb commented Nov 11, 2016

r? @jonathandturner

@rust-highfive rust-highfive assigned sophiajt and unassigned eddyb Nov 11, 2016
@sophiajt
Copy link
Contributor

Unfortunately, while this helps with some platforms, other platforms like Windows can't experience it. In the RFC for the new error format, we call out that Unicode should not be supported: https://github.com/rust-lang/rfcs/blob/master/text/1644-default-and-expanded-rustc-errors.md#format-of-error-messages

That said, there are probably ways we can improve some of our ascii drawing for better readability in some cases, like the multiline case.

@bors
Copy link
Contributor

bors commented Nov 23, 2016

☔ The latest upstream changes (presumably #37681) made this pull request unmergeable. Please resolve the merge conflicts.

@steveklabnik
Copy link
Member

@jonathandturner I'm going to take that comment as an "this should be closed", then. Let me know if that's wrong!

Thanks @estebank but we can't accept this patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants