On fmt string with unescaped { note how to escape
#37695
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @aturon (rust_highfive has picked a reviewer for you, use r? to override) |
|
Awesome, thanks! Could you be sure to add a ui test for this case as well? |
estebank
force-pushed
the
unescaped-curly
branch
from
21233aa
to
1631a5c
Compare
|
@alexcrichton added NOTE for |
|
@bors: r+ Thanks! |
|
📌 Commit 1631a5c has been approved by |
brson
reviewed
Nov 11, 2016
| self.err("unmatched `}` found"); | ||
| self.err_with_note("unmatched `}` found", | ||
| "if you intended to print `}`, \ | ||
| can you escape it using `}}`"); |
brson
reviewed
Nov 11, 2016
| let msg = &format!("expected `{:?}` but string was terminated", c); | ||
| if c == '}' { | ||
| self.err_with_note(msg, | ||
| "if you intended to print `{`, can you escape it using `{{`"); |
There was a problem hiding this comment.
Ditto. "can you" -> "you can"
|
@bors: r- (waiting for changes) |
On cases of malformed format strings where a `{` hasn't been properly
escaped, like `println!("{");`, present a note explaining how to escape
the `{` char.
estebank
force-pushed
the
unescaped-curly
branch
from
1631a5c
to
3c17abc
Compare
|
@brson @alexcrichton fixed. |
|
@bors: r+ |
|
📌 Commit 3c17abc has been approved by |
eddyb
added a commit
to eddyb/rust
that referenced
this pull request
Nov 11, 2016
…chton
On fmt string with unescaped `{` note how to escape
On cases of malformed format strings where a `{` hasn't been properly escaped, like `println!("{");`, present a NOTE explaining how to escape the `{` char.
Fix rust-lang#34300.
eddyb
added a commit
to eddyb/rust
that referenced
this pull request
Nov 12, 2016
…chton
On fmt string with unescaped `{` note how to escape
On cases of malformed format strings where a `{` hasn't been properly escaped, like `println!("{");`, present a NOTE explaining how to escape the `{` char.
Fix rust-lang#34300.
bors
added a commit
that referenced
this pull request
Nov 12, 2016
Rollup of 30 pull requests - Successful merges: #37190, #37368, #37481, #37503, #37527, #37535, #37551, #37584, #37600, #37613, #37615, #37659, #37662, #37669, #37682, #37688, #37690, #37692, #37693, #37694, #37695, #37696, #37698, #37699, #37705, #37708, #37709, #37716, #37724, #37727 - Failed merges: #37640, #37689, #37717
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On cases of malformed format strings where a
{hasn't been properly escaped, likeprintln!("{");, present a NOTE explaining how to escape the{char.Fix #34300.