Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use gpgv for signature verification in cargo #3764

Merged
merged 1 commit into from
Oct 17, 2012
Merged

Use gpgv for signature verification in cargo #3764

merged 1 commit into from
Oct 17, 2012

Conversation

lucab
Copy link
Contributor

@lucab lucab commented Oct 14, 2012

Parsing gpg output for signature verification is not recommended,
as it can break easily (and doesn't work with i18n).
This patch makes use of gpgv, as suggested by gpg authors:
http://lists.gnupg.org/pipermail/gnupg-users/2004-August/023141.html
This closes #3762.

Signed-off-by: Luca Bruno [email protected]

Parsing gpg output for signature verification is not recommended,
as it can break easily (and doesn't work with i18n).
This patch makes use of gpgv, as suggested by gpg authors:
http://lists.gnupg.org/pipermail/gnupg-users/2004-August/023141.html
This closes #3762.

Signed-off-by: Luca Bruno <[email protected]>
@killerswan
Copy link
Contributor

Oh, good catch!

catamorphism added a commit that referenced this pull request Oct 17, 2012
Use gpgv for signature verification in cargo
@catamorphism catamorphism merged commit 5cf0c65 into rust-lang:incoming Oct 17, 2012
@catamorphism
Copy link
Contributor

Thanks!

flip1995 pushed a commit to flip1995/rust that referenced this pull request Jul 14, 2020
…1995

Improvements for `type_repetition_in_bounds` lint

Some improvements for `type_repetition_in_bounds`:
- add a configurable threshold to trigger the lint (rust-lang#4380). The lint won't trigger anymore if there are more bounds (strictly) than `conf.max_trait_bounds` on this type.
- take generic args into account over bounded type (rust-lang#4323)
- don't lint for predicates generated in macros (rust-lang#4326)

Fixes rust-lang#4380,
Fixes rust-lang#4323,
Fixes rust-lang#4326,
Closes rust-lang#3764

changelog: Fix multiple FPs in `type_repetition_in_bounds` and add a configuration option

Note: the rust-lang#3764 has already been fixed but not closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants