Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stop having identity casts be lexprs #36942

Merged
merged 1 commit into from
Oct 5, 2016
Merged

stop having identity casts be lexprs #36942

merged 1 commit into from
Oct 5, 2016

Conversation

arielb1
Copy link
Contributor

@arielb1 arielb1 commented Oct 3, 2016

that made no sense (see test), and was incompatible with borrowck.

Fixes #36936.

beta-nominated since (bad) regression.

r? @eddyb

@arielb1
stop having identity casts be lexprs
c2a0859 
that made no sense (see test), and was incompatible with borrowck.

Fixes rust-lang#36936.
@arielb1 arielb1 added the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 3, 2016
@eddyb
Copy link
Member

eddyb commented Oct 3, 2016

@bors r+

@bors
Copy link
Contributor

bors commented Oct 3, 2016

📌 Commit c2a0859 has been approved by eddyb

@alexcrichton
Copy link
Member

@bors: p=1

(fixing a regression)

@bors
Copy link
Contributor

bors commented Oct 5, 2016

⌛ Testing commit c2a0859 with merge 165a03d...

bors added a commit that referenced this pull request Oct 5, 2016
@bors
Auto merge of #36942 - arielb1:cast-lifetimes, r=eddyb
165a03d 
stop having identity casts be lexprs

that made no sense (see test), and was incompatible with borrowck.

Fixes #36936.

beta-nominated since (bad) regression.

r? @eddyb
@bors
Copy link
Contributor

bors commented Oct 5, 2016

☀️ Test successful - auto-linux-32-nopt-t, auto-linux-32-opt, auto-linux-64-cargotest, auto-linux-64-cross-freebsd, auto-linux-64-debug-opt, auto-linux-64-nopt-t, auto-linux-64-opt, auto-linux-64-opt-rustbuild, auto-linux-64-x-android-t, auto-linux-cross-opt, auto-linux-musl-64-opt, auto-mac-32-opt, auto-mac-64-opt, auto-mac-64-opt-rustbuild, auto-mac-cross-ios-opt, auto-win-gnu-32-opt, auto-win-gnu-32-opt-rustbuild, auto-win-gnu-64-opt, auto-win-msvc-32-opt, auto-win-msvc-64-cargotest, auto-win-msvc-64-opt, auto-win-msvc-64-opt-rustbuild
Approved by: eddyb
Pushing 165a03d to master...

@bors bors merged commit c2a0859 into rust-lang:master Oct 5, 2016
@brson brson added I-nominated T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Oct 5, 2016
@nikomatsakis nikomatsakis added beta-accepted Accepted for backporting to the compiler in the beta channel. beta-nominated Nominated for backporting to the compiler in the beta channel. and removed beta-nominated Nominated for backporting to the compiler in the beta channel. labels Oct 11, 2016
@nikomatsakis
Copy link
Contributor

Accepting for beta because small patch, regression.

cc @rust-lang/compiler

@alexcrichton alexcrichton mentioned this pull request Oct 11, 2016
Merged
@brson brson removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Oct 11, 2016
@brson brson mentioned this pull request Oct 14, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eddyb eddyb eddyb approved these changes

Assignees

@eddyb eddyb

Labels
beta-accepted Accepted for backporting to the compiler in the beta channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@arielb1 @eddyb @bors @alexcrichton @nikomatsakis @brson