Don't let a type parameter named "Self" unchanged past HIR lowering. #36649
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
|
@eddyb I'm surprised; can't we catch the error here during parsing, rather than taking this (IMO strange) workaround? Is the parser not set up to do so? Or am I not thinking about this the right way? |
|
@pnkfelix The parser errors but it uses the keyword as an identifier and continues compilation. |
|
@eddyb Hmm, I see. Okay. Its still pretty bizarre but I guess I don't have any solid objection. |
|
@bors r+ |
|
📌 Commit 795b6ad has been approved by |
|
⌛ Testing commit 795b6ad with merge cb1b1ee... |
bors
added a commit
that referenced
this pull request
Sep 23, 2016
Don't let a type parameter named "Self" unchanged past HIR lowering. Fixes #36638 by rewriting `Self` type parameters (which are a parse error) to a `gensym("Self")`. Background: #35605 introduced code across rustc that determines `Self` by its keyword name. Reverting the sanity checks around that would inadvertently cause confusion between the true `Self` of a `trait` and other type parameters named `Self` (which have caused parse errors already). I do not like to use `gensym`, and we may do something different here in the future, but this should work.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #36638 by rewriting
Selftype parameters (which are a parse error) to agensym("Self").Background: #35605 introduced code across rustc that determines
Selfby its keyword name.Reverting the sanity checks around that would inadvertently cause confusion between the true
Selfof atraitand other type parameters namedSelf(which have caused parse errors already).I do not like to use
gensym, and we may do something different here in the future, but this should work.