Replace 'e.g.' by 'i.e.' #36578
Replace 'e.g.' by 'i.e.' #36578
Conversation
|
You are the man! \o/ |
There was a problem hiding this comment.
So, 'eg' is "for example", and ie is "in other words". That is, ie is for when things are equivalent, but eg is for providing one of many examples. Because I'm not 100% sure of the behavior of these functions, I'm not 100% sure which is correct here. Maybe @rust-lang/libs can chime in?
| @@ -83,7 +83,7 @@ impl Duration { | |||
|
|
|||
| /// Returns the number of whole seconds represented by this duration. | |||
| /// | |||
| /// The extra precision represented by this duration is ignored (e.g. extra | |||
| /// The extra precision represented by this duration is ignored (i.e. extra | |||
There was a problem hiding this comment.
I am not 100% sure of this one, mostly because I don't remember the exact semantics of this function.
There was a problem hiding this comment.
I believe the change here is correct - the extra nanoseconds is the only thing dropped.
| @@ -93,7 +93,7 @@ impl Duration { | |||
| /// | |||
| /// This method does **not** return the length of the duration when | |||
| /// represented by nanoseconds. The returned number always represents a | |||
| /// fractional portion of a second (e.g. it is less than one billion). | |||
| /// fractional portion of a second (i.e. it is less than one billion). | |||
There was a problem hiding this comment.
Same deal, this change seems right.
|
Hm, looks like @rust-lang/libs (a team) didn't get tagged in the review comment. @jessicard, (who I understand implemented this for GitHub) is that the expected behavior of the review summary feature? Don't worry about it, but figured I'd mention it. |
|
📌 Commit 313fb8f has been approved by |
|
@steveklabnik Oh no! Tagging in a review summary is currently broken, but we've got it on our TODO list. Sorry about that, and thanks for letting me know ❤️ |
…bnik Replace 'e.g.' by 'i.e.' Fixes rust-lang#36577. r? @steveklabnik
…bnik Replace 'e.g.' by 'i.e.' Fixes rust-lang#36577. r? @steveklabnik
…bnik Replace 'e.g.' by 'i.e.' Fixes rust-lang#36577. r? @steveklabnik
Fixes #36577.
r? @steveklabnik