-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not emit "class method" debuginfo for types that are not DICompositeType. #36008
Conversation
cc @tromey: It seems like LLVM doesn't allow us to put methods on non-class types. Does the current version GDB rely on that in any way yet? |
@bors r+ Since LLVM does not allow this anymore, there's little we can do in the short term. In the long term, we'll need a different strategy for associating methods with their self types anyway, since this one doesn't scale to trait methods. |
📌 Commit 8407952 has been approved by |
@bors: p=10 (fixing nightlies) |
No. IIRC this was just in our draft proposal for how interface impls ought to be represented, not anything that was actually implemented (or even actually proposed)? |
@tromey Good, so this doesn't make things worse at least. |
Do not emit "class method" debuginfo for types that are not DICompositeType. Fixes #35991 by restricting the "class method" debuginfo sugar from #33358 to structs and enums only. r? @michaelwoerister
Fixes #35991 by restricting the "class method" debuginfo sugar from #33358 to structs and enums only.
r? @michaelwoerister