replace Neg example with something more evocative of negation
#35830
Conversation
|
(rust_highfive has picked a reviewer for you, use r? to override) |
| @@ -470,26 +470,37 @@ rem_impl_float! { f32 f64 } | |||
| /// | |||
| /// # Examples | |||
| /// | |||
| /// A trivial implementation of `Neg`. When `-Foo` happens, it ends up calling | |||
| /// `neg`, and therefore, `main` prints `Negating!`. | |||
| /// An implementation of `Neg` for `Sign`, which allows the use of `-` to | |||
There was a problem hiding this comment.
comma might be incorrect here
There was a problem hiding this comment.
I don't believe so. It's a non-restrictive which clause.
There was a problem hiding this comment.
Correction: the comma might be unnecessary, not strictly incorrect.
There was a problem hiding this comment.
I like how relevant your avatar is for this PR, given that it's a cyclic set of invertible elements. :P
There was a problem hiding this comment.
I stand by the necessity of this comma (Strunk & White II.3), but I certainly won't fight to the death over it. I'm happy to remove it if it truly feels awkward to read.
There was a problem hiding this comment.
I would put the comma here, but I also tend to use commas a lot more than most people.
There was a problem hiding this comment.
no no, you have convinced me. not that you needed to 😄
|
These examples are far clearer. Thanks |
|
@bors: r+ rollup thanks! |
|
📌 Commit c0eccb1 has been approved by |
…klabnik replace `Neg` example with something more evocative of negation
…klabnik replace `Neg` example with something more evocative of negation
…klabnik replace `Neg` example with something more evocative of negation
No description provided.