prohibit splitting literal patterns #35664
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Before PR rust-lang#32202, check_match tended to report bogus errors or ICE when encountering a pattern that split a literal, e.g. ```Rust match foo { "bar" => {}, &_ => {} } ``` That PR fixed these issues, but trans::_match generates bad code when it encounters these matches. MIR trans has that fixed, but it is waiting for 6 weeks in beta. Report an error when encountering these instead. Fixes issue rust-lang#35044.
|
cc @brson |
|
r? @pnkfelix (rust_highfive has picked a reviewer for you, use r? to override) |
|
|
|
Hm we're cutting it really close for a fix like this, the stable build kicks off tomorrow. Are we pretty confident in this change? @arielb1 does this already exist on master and is being tested? I'd be fine merging a fix but just want to make sure it warrants last-minute very-little-testing status. |
|
On master we use MIR, so we do not need the temporary restriction. |
|
LGTM, @nikomatsakis what do you think? |
|
r+ from me I agree with @alexcrichton that this is cutting it close, but this is a fairly simple change. Seems about as close to "risk free" as you can get. |
pmatos
pushed a commit
to LinkiTools/rust
that referenced
this pull request
Sep 27, 2016
prohibit splitting literal patterns
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before PR #32202,
check_matchtended to report bogus errors or ICEwhen encountering a pattern that split a literal, e.g.
That PR fixed these issues, but
trans::_matchgenerates bad codewhen it encounters these matches. MIR trans has that fixed, but
it is waiting for 6 weeks in beta. Report an error when encountering
these instead.
Fixes issue #35044.