Rollup of 19 pull requests #35462

sophiajt · 2016-08-07T14:25:23Z

Successful merges: Updates compiler error E0046 with new format #35355, Updates compiler error E0040 with new format #35357, Updated error message E0252 #35362, Updated error message E0282 #35366, Update error format #35304 #35394, Update E0206 message to new format #35402, Update compiler error 0027 to use new error format. #35410, Update E0223 to the new format #35411, Update E0220 message to new format #35412, Update compiler error 0029 to use new error format. #35413, E0131 updated to new format #35417, Update error message for E0243 and E0244 #35419, Updated E0225 to new format. #35421, Indicate tracking issue for exact_size_is_empty unstability. #35429, Fix build on DragonFly (unused function errno_location) #35433, Fixing compiler error E0121 #35434, Add doc example for std::ffi::NulError::into_vec. #35436, New error message format for E0117 and E0118 #35454, Update E0204 to the new error format #35455
Failed merges: Update E0057 error message to new format #35395, Update compiler error 0030 to use new error format. #35415

Function errno_location() is not used on DragonFly. As warnings are errors, this breaks the build.

Fixes rust-lang#35251 Also changes the span of the error to the span of the type as suggested in the bonus section of rust-lang#35251

Updates compiler error E0046 with new format Addresses rust-lang#35209 as part of rust-lang#35233. r? @jonathandturner I've repeated the following in my code. If this is something not desirable then let me know if there's any process to make this any cleaner. Thank you. ```rust missing_items.iter() .map(|name| name.to_string()) .collect::<Vec<_>>().join("`, `")) ```

@GuillaumeGomez

Updates compiler error E0040 with new format Addresses rust-lang#35208 as part of rust-lang#35233. r? @GuillaumeGomez

@GuillaumeGomez

Updated error message E0252 Fixes rust-lang#35306 as part of rust-lang#35233. r? @GuillaumeGomez

@GuillaumeGomez

Updated error message E0282 Fixes rust-lang#35312 as part of rust-lang#35233. r? @GuillaumeGomez

Update error format rust-lang#35304 Fixes rust-lang#35304 as part of rust-lang#35233. r? @jonathandturner

@GuillaumeGomez

…Gomez Update E0206 message to new format Part of rust-lang#35233. Fixes rust-lang#35301. r? @GuillaumeGomez

…andturner Update compiler error 0027 to use new error format. Part of rust-lang#35233, Addresses rust-lang#35200 r? @jonathandturner

…andturner Update E0223 to the new format Part of rust-lang#35233. Fixes rust-lang#35387. r? @jonathandturner

Update E0220 message to new format Part of rust-lang#35233 . Fixes rust-lang#35385. r? @jonathandturner Should it keep E0191?

…andturner Update compiler error 0029 to use new error format. Part of rust-lang#35233, Addresses rust-lang#35201 r? @jonathandturner

E0131 updated to new format Changes ``` error[E0131]: main function is not allowed to have type parameters --> src/test/compile-fail/E0131.rs:11:1 | 11 | fn main<T>() { //~ ERROR E0131 | ^ ``` to ``` error[E0131]: main function is not allowed to have type parameters --> src/test/compile-fail/E0131.rs:11:1 | 11 | fn main<T>() { //~ ERROR E0131 | ^^^ main cannot have type parameters ``` Fixes rust-lang#35257. Part of rust-lang#35233. r? @jonathandturner

Update error message for E0243 and E0244 Fixes rust-lang#35389 and rust-lang#35390 as part of rust-lang#35233. r? @jonathandturner

…t, r=jonathandturner Updated E0225 to new format. Part of rust-lang#35233. Fixes rust-lang#35388. r? @jonathandturner

…l422 Indicate tracking issue for `exact_size_is_empty` unstability. rust-lang#35428

…-location, r=alexcrichton Fix build on DragonFly (unused function errno_location) Function errno_location() is not used on DragonFly. As warnings are errors, this breaks the build.

…=jonathandturner Fixing compiler error E0121 Fixes rust-lang#35254 and part of rust-lang#35233

Add doc example for `std::ffi::NulError::into_vec`. None

New error message format for E0117 and E0118 Part of rust-lang#35233 r? @jonathandturner

Update E0204 to the new error format Part of rust-lang#35233 Addresses rust-lang#35381 "r? @jonathandturner

rust-highfive · 2016-08-07T14:25:29Z

r? @arielb1

(rust_highfive has picked a reviewer for you, use r? to override)

sophiajt · 2016-08-07T14:25:36Z

@bors r+ p=1

bors · 2016-08-07T14:25:37Z

📌 Commit 1703f87 has been approved by jonathandturner

TimNN · 2016-08-07T16:11:31Z

A local build of this PR had some test failures:

failures:

---- [compile-fail] compile-fail/E0206.rs stdout ----

error: /home/logic/build/rust/src/test/compile-fail/E0206.rs:13: unexpected "note": 'impl doesn't use types inside crate'

error: /home/logic/build/rust/src/test/compile-fail/E0206.rs:13: unexpected "note": '13:1: 13:22: the impl does not reference any types defined in this crate'

error: 2 unexpected errors found, 0 expected errors not found
status: exit code: 101
command: /home/logic/build/rust-out/dev-build/build/x86_64-unknown-linux-gnu/stage2/bin/rustc /home/logic/build/rust/src/test/compile-fail/E0206.rs -L /home/logic/build/rust-out/dev-build/build/x86_64-unknown-linux-gnu/test/compile-fail --target=x86_64-unknown-linux-gnu --error-format json -Z unstable-options -L /home/logic/build/rust-out/dev-build/build/x86_64-unknown-linux-gnu/test/compile-fail/E0206.stage2-x86_64-unknown-linux-gnu.compile-fail.libaux -C prefer-dynamic -o /home/logic/build/rust-out/dev-build/build/x86_64-unknown-linux-gnu/test/compile-fail/E0206.stage2-x86_64-unknown-linux-gnu -Crpath -O -Lnative=/home/logic/build/rust-out/dev-build/build/x86_64-unknown-linux-gnu/rust-test-helpers
unexpected errors (from JSON output): [
    Error {
        line_num: 13,
        kind: Some(
            Note
        ),
        msg: "impl doesn\'t use types inside crate"
    },
    Error {
        line_num: 13,
        kind: Some(
            Note
        ),
        msg: "13:1: 13:22: the impl does not reference any types defined in this crate"
    }
]

thread '[compile-fail] compile-fail/E0206.rs' panicked at 'Box<Any>', /home/logic/build/rust/src/tools/compiletest/src/runtest.rs:1082
note: Run with `RUST_BACKTRACE=1` for a backtrace.

---- [compile-fail] compile-fail/E0220.rs stdout ----

error: /home/logic/build/rust/src/test/compile-fail/E0220.rs:15: unexpected "error": '15:12: 15:24: the value of the associated type `Bar` (from the trait `Trait`) must be specified [E0191]'

error: /home/logic/build/rust/src/test/compile-fail/E0220.rs:16: expected error not found: E0191

error: 1 unexpected errors found, 1 expected errors not found
status: exit code: 101
command: /home/logic/build/rust-out/dev-build/build/x86_64-unknown-linux-gnu/stage2/bin/rustc /home/logic/build/rust/src/test/compile-fail/E0220.rs -L /home/logic/build/rust-out/dev-build/build/x86_64-unknown-linux-gnu/test/compile-fail --target=x86_64-unknown-linux-gnu --error-format json -Z unstable-options -L /home/logic/build/rust-out/dev-build/build/x86_64-unknown-linux-gnu/test/compile-fail/E0220.stage2-x86_64-unknown-linux-gnu.compile-fail.libaux -C prefer-dynamic -o /home/logic/build/rust-out/dev-build/build/x86_64-unknown-linux-gnu/test/compile-fail/E0220.stage2-x86_64-unknown-linux-gnu -Crpath -O -Lnative=/home/logic/build/rust-out/dev-build/build/x86_64-unknown-linux-gnu/rust-test-helpers
unexpected errors (from JSON output): [
    Error {
        line_num: 15,
        kind: Some(
            Error
        ),
        msg: "15:12: 15:24: the value of the associated type `Bar` (from the trait `Trait`) must be specified [E0191]"
    }
]

not found errors (from test file): [
    Error {
        line_num: 16,
        kind: Some(
            Error
        ),
        msg: "E0191"
    }
]

thread '[compile-fail] compile-fail/E0220.rs' panicked at 'Box<Any>', /home/logic/build/rust/src/tools/compiletest/src/runtest.rs:1082

---- [compile-fail] compile-fail/coherence-impls-copy.rs stdout ----

error: /home/logic/build/rust/src/test/compile-fail/coherence-impls-copy.rs:34: unexpected "note": 'impl doesn't use types inside crate'

error: /home/logic/build/rust/src/test/compile-fail/coherence-impls-copy.rs:34: unexpected "note": '34:1: 34:34: the impl does not reference any types defined in this crate'

error: /home/logic/build/rust/src/test/compile-fail/coherence-impls-copy.rs:43: unexpected "note": 'impl doesn't use types inside crate'

error: /home/logic/build/rust/src/test/compile-fail/coherence-impls-copy.rs:43: unexpected "note": '43:1: 43:26: the impl does not reference any types defined in this crate'

error: /home/logic/build/rust/src/test/compile-fail/coherence-impls-copy.rs:48: unexpected "note": 'impl doesn't use types inside crate'

error: /home/logic/build/rust/src/test/compile-fail/coherence-impls-copy.rs:48: unexpected "note": '48:1: 48:36: the impl does not reference any types defined in this crate'

error: 6 unexpected errors found, 0 expected errors not found
status: exit code: 101
command: /home/logic/build/rust-out/dev-build/build/x86_64-unknown-linux-gnu/stage2/bin/rustc /home/logic/build/rust/src/test/compile-fail/coherence-impls-copy.rs -L /home/logic/build/rust-out/dev-build/build/x86_64-unknown-linux-gnu/test/compile-fail --target=x86_64-unknown-linux-gnu --error-format json -Z unstable-options -L /home/logic/build/rust-out/dev-build/build/x86_64-unknown-linux-gnu/test/compile-fail/coherence-impls-copy.stage2-x86_64-unknown-linux-gnu.compile-fail.libaux -C prefer-dynamic -o /home/logic/build/rust-out/dev-build/build/x86_64-unknown-linux-gnu/test/compile-fail/coherence-impls-copy.stage2-x86_64-unknown-linux-gnu -Crpath -O -Lnative=/home/logic/build/rust-out/dev-build/build/x86_64-unknown-linux-gnu/rust-test-helpers
unexpected errors (from JSON output): [
    Error {
        line_num: 34,
        kind: Some(
            Note
        ),
        msg: "impl doesn\'t use types inside crate"
    },
    Error {
        line_num: 34,
        kind: Some(
            Note
        ),
        msg: "34:1: 34:34: the impl does not reference any types defined in this crate"
    },
    Error {
        line_num: 43,
        kind: Some(
            Note
        ),
        msg: "impl doesn\'t use types inside crate"
    },
    Error {
        line_num: 43,
        kind: Some(
            Note
        ),
        msg: "43:1: 43:26: the impl does not reference any types defined in this crate"
    },
    Error {
        line_num: 48,
        kind: Some(
            Note
        ),
        msg: "impl doesn\'t use types inside crate"
    },
    Error {
        line_num: 48,
        kind: Some(
            Note
        ),
        msg: "48:1: 48:36: the impl does not reference any types defined in this crate"
    }
]

thread '[compile-fail] compile-fail/coherence-impls-copy.rs' panicked at 'Box<Any>', /home/logic/build/rust/src/tools/compiletest/src/runtest.rs:1082

---- [compile-fail] compile-fail/unboxed-closure-sugar-wrong-trait.rs stdout ----

error: /home/logic/build/rust/src/test/compile-fail/unboxed-closure-sugar-wrong-trait.rs:15: unexpected "note": 'associated `Output` not found in `Trait`'

error: 1 unexpected errors found, 0 expected errors not found
status: exit code: 101
command: /home/logic/build/rust-out/dev-build/build/x86_64-unknown-linux-gnu/stage2/bin/rustc /home/logic/build/rust/src/test/compile-fail/unboxed-closure-sugar-wrong-trait.rs -L /home/logic/build/rust-out/dev-build/build/x86_64-unknown-linux-gnu/test/compile-fail --target=x86_64-unknown-linux-gnu --error-format json -Z unstable-options -L /home/logic/build/rust-out/dev-build/build/x86_64-unknown-linux-gnu/test/compile-fail/unboxed-closure-sugar-wrong-trait.stage2-x86_64-unknown-linux-gnu.compile-fail.libaux -C prefer-dynamic -o /home/logic/build/rust-out/dev-build/build/x86_64-unknown-linux-gnu/test/compile-fail/unboxed-closure-sugar-wrong-trait.stage2-x86_64-unknown-linux-gnu -Crpath -O -Lnative=/home/logic/build/rust-out/dev-build/build/x86_64-unknown-linux-gnu/rust-test-helpers
unexpected errors (from JSON output): [
    Error {
        line_num: 15,
        kind: Some(
            Note
        ),
        msg: "associated `Output` not found in `Trait`"
    }
]

thread '[compile-fail] compile-fail/unboxed-closure-sugar-wrong-trait.rs' panicked at 'Box<Any>', /home/logic/build/rust/src/tools/compiletest/src/runtest.rs:1082


failures:
    [compile-fail] compile-fail/E0206.rs
    [compile-fail] compile-fail/E0220.rs
    [compile-fail] compile-fail/coherence-impls-copy.rs
    [compile-fail] compile-fail/unboxed-closure-sugar-wrong-trait.rs

sophiajt · 2016-08-07T16:17:16Z

@bors r-

TimNN · 2016-08-07T16:17:20Z

I believe the failures in E0206.rs and coherence-impls-copy.rs are from #35402 due to now missing notes.

sophiajt · 2016-08-07T16:17:41Z

@TimNN - thanks for the catch.

TimNN · 2016-08-07T16:19:13Z

The E0220.rs failures also seems to be due to now missing notes (#35412).

TimNN · 2016-08-07T16:20:40Z

unboxed-closure-sugar-wrong-trait.rs seems to be #35412 as well.

sophiajt · 2016-08-07T16:58:55Z

Closing so I can reroll now that there are new PRs

mikhail-m1 and others added 30 commits August 5, 2016 18:57

Fixes rust-lang#35304

2f5294e

Merge branch 'master' of https://github.com/rust-lang/rust

e7e5cfe

Update E0206 message to new format

5bab0e6

Update E0223 to the new format

065c685

Update compiler error 0027 to use new error format.

c9e9d42

Update compiler error 0029 to use new error format.

1d25e2e

Updated error message E0252

f4dd1f9

Updated E0225 to new format.

eb469d6

Fixing compiler error E0121

6eba89e

Indicate tracking issue for exact_size_is_empty unstability.

95cce86

Updated error message E0282

19e4579

Fix build on DragonFly (unused function errno_location)

e8da915

Function errno_location() is not used on DragonFly. As warnings are errors, this breaks the build.

Add doc example for std::ffi::NulError::into_vec.

0a6b862

E0131 updated to new format

5e06da2

Update error message for E0243 and E0244

02f3609

Update E0220 message to new format

0e13b63

Update error E0117 to new format

ac10b5f

Fixes rust-lang#35250

Update error E0118 to new format

e91f3f6

Fixes rust-lang#35251 Also changes the span of the error to the span of the type as suggested in the bonus section of rust-lang#35251

Update E0204 to the new error format

54e1e98

Updates compiler error E0046 with new format

ed72c65

Updates compiler error E0040 with new format

b564c6a

Rollup merge of rust-lang#35357 - shri3k:E0040, r=jonathandturner

feb458d

Updates compiler error E0040 with new format Addresses rust-lang#35208 as part of rust-lang#35233. r? @GuillaumeGomez

Rollup merge of rust-lang#35362 - medzin:E0252, r=GuillaumeGomez

262c91f

Updated error message E0252 Fixes rust-lang#35306 as part of rust-lang#35233. r? @GuillaumeGomez

Rollup merge of rust-lang#35366 - medzin:E0282, r=jonathandturner

5b22d2b

Updated error message E0282 Fixes rust-lang#35312 as part of rust-lang#35233. r? @GuillaumeGomez

Rollup merge of rust-lang#35394 - mikhail-m1:master, r=jonathandturner

d556e04

Update error format rust-lang#35304 Fixes rust-lang#35304 as part of rust-lang#35233. r? @jonathandturner

Rollup merge of rust-lang#35402 - KiChjang:e0206-new-msg, r=Guillaume…

d58d045

…Gomez Update E0206 message to new format Part of rust-lang#35233. Fixes rust-lang#35301. r? @GuillaumeGomez

Rollup merge of rust-lang#35410 - silenuss:e0027-formatting, r=jonath…

b5261aa

…andturner Update compiler error 0027 to use new error format. Part of rust-lang#35233, Addresses rust-lang#35200 r? @jonathandturner

Rollup merge of rust-lang#35411 - KiChjang:e0223-new-format, r=jonath…

f40b2ff

…andturner Update E0223 to the new format Part of rust-lang#35233. Fixes rust-lang#35387. r? @jonathandturner

Rollup merge of rust-lang#35412 - chamoysvoice:e0220, r=jonathandturner

eb9db9f

Update E0220 message to new format Part of rust-lang#35233 . Fixes rust-lang#35385. r? @jonathandturner Should it keep E0191?

Jonathan Turner added 10 commits August 7, 2016 07:25

Rollup merge of rust-lang#35413 - silenuss:e0029-formatting, r=jonath…

3251520

…andturner Update compiler error 0029 to use new error format. Part of rust-lang#35233, Addresses rust-lang#35201 r? @jonathandturner

Rollup merge of rust-lang#35419 - Keats:err-243, r=jonathandturner

2da9967

Update error message for E0243 and E0244 Fixes rust-lang#35389 and rust-lang#35390 as part of rust-lang#35233. r? @jonathandturner

Rollup merge of rust-lang#35421 - razielgn:updated-e0225-to-new-forma…

abbfb1f

…t, r=jonathandturner Updated E0225 to new format. Part of rust-lang#35233. Fixes rust-lang#35388. r? @jonathandturner

Rollup merge of rust-lang#35429 - frewsxcv:tracking-is-empty, r=apase…

26f137b

…l422 Indicate tracking issue for `exact_size_is_empty` unstability. rust-lang#35428

Rollup merge of rust-lang#35433 - mneumann:dragonfly-fix-libstd-errno…

71aa493

…-location, r=alexcrichton Fix build on DragonFly (unused function errno_location) Function errno_location() is not used on DragonFly. As warnings are errors, this breaks the build.

Rollup merge of rust-lang#35434 - intrepion:fix-compile-fail-e0121, r…

f04b440

…=jonathandturner Fixing compiler error E0121 Fixes rust-lang#35254 and part of rust-lang#35233

Rollup merge of rust-lang#35436 - frewsxcv:into-vec, r=GuillaumeGomez

db04c10

Add doc example for `std::ffi::NulError::into_vec`. None

Rollup merge of rust-lang#35454 - Detegr:master, r=jonathandturner

236c089

New error message format for E0117 and E0118 Part of rust-lang#35233 r? @jonathandturner

Rollup merge of rust-lang#35455 - munyari:e0204, r=jonathandturner

1703f87

Update E0204 to the new error format Part of rust-lang#35233 Addresses rust-lang#35381 "r? @jonathandturner

rust-highfive assigned arielb1 Aug 7, 2016

This was referenced Aug 7, 2016

Update E0206 message to new format #35402

Merged

Update E0220 message to new format #35412

Closed

sophiajt closed this Aug 7, 2016

Centril added the rollup A PR which is a rollup label Oct 24, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 19 pull requests #35462

Rollup of 19 pull requests #35462

sophiajt commented Aug 7, 2016

rust-highfive commented Aug 7, 2016

sophiajt commented Aug 7, 2016

bors commented Aug 7, 2016

TimNN commented Aug 7, 2016

sophiajt commented Aug 7, 2016

TimNN commented Aug 7, 2016

sophiajt commented Aug 7, 2016

TimNN commented Aug 7, 2016

TimNN commented Aug 7, 2016

sophiajt commented Aug 7, 2016

Rollup of 19 pull requests #35462

Rollup of 19 pull requests #35462

Conversation

sophiajt commented Aug 7, 2016

rust-highfive commented Aug 7, 2016

sophiajt commented Aug 7, 2016

bors commented Aug 7, 2016

TimNN commented Aug 7, 2016

sophiajt commented Aug 7, 2016

TimNN commented Aug 7, 2016

sophiajt commented Aug 7, 2016

TimNN commented Aug 7, 2016

TimNN commented Aug 7, 2016

sophiajt commented Aug 7, 2016