-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update compiler error 0093 to use new error format #35346
Conversation
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @jonathandturner (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
Looks good, but I noticed an extra space at the end of one of the lines. Before it's ready you'll need to run it through tidy:
And fix any warnings it has. |
Ah, and one more point (sorry, should have mentioned this earlier). Be sure to also update the unit test so that it's also testing for the new label. |
Great. Looks almost ready. Last step, can you squash your 3 commits down to 1 commit? |
Thank you for patience. Probably I have done something wrong with merge... |
So explanations to squash your commits (I should create a blog post about it haha). First: git rebase -i HEAD~5 (5 corresponds to your commit number). Then replace all "pick" by "s" except the one at the top. Confirm and save. Now add a "#" in front of all commit's comments you don't want (so normally all except the one at the top). Once this done, push the new git history like this: git push -f origin HEAD:your_branch_name
|
7c0eb51
to
59b3e8c
Compare
59b3e8c
to
127489a
Compare
Strange failure. I suppose it is not caused by my changes?.. |
@DarkEld3r - Travis CI was down the other day. I'm guessing this is related to that. Looks good now, that's for squashing. @bors r+ rollup |
📌 Commit 127489a has been approved by |
…handturner Update compiler error 0093 to use new error format Addresses rust-lang#35230, Part of the rust-lang#35233 meta bug r? @jonathandturner
…handturner Update compiler error 0093 to use new error format Addresses rust-lang#35230, Part of the rust-lang#35233 meta bug r? @jonathandturner
@bors r- failed on travis |
Did something go wrong? Should I do something or just wait patiently? |
@eddyb: Travis didn't start correctly so I restarted it. |
@bors r=jonathandturner rollup |
📌 Commit 127489a has been approved by |
…handturner Update compiler error 0093 to use new error format Addresses rust-lang#35230, Part of the rust-lang#35233 meta bug r? @jonathandturner
Addresses #35230, Part of the #35233 meta bug
r? @jonathandturner