Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run base::internalize_symbols() even for single-codegen-unit crates. #34899

Merged
merged 1 commit into from
Jul 18, 2016
Merged

Run base::internalize_symbols() even for single-codegen-unit crates. #34899

merged 1 commit into from
Jul 18, 2016

Commits on Jul 18, 2016

  1. Run base::internalize_symbols() even for single-codegen-unit crates. 

    The initial linkage-assignment (especially for closures) is a conservative one that makes some symbols more visible than they need to be. While this is not a correctness problem, it does force the LLVM inliner to be more conservative too, which results in poor performance. Once translation is based solely on MIR, it will be easier to also make the initial linkage assignment a better fitting one. Until then `internalize_symbols()` does a good job of preventing most performance regressions.
    @michaelwoerister
    michaelwoerister committed Jul 18, 2016
    Configuration menu
    Copy the full SHA
    22f77a9 View commit details
    Browse the repository at this point in the history